Skip to content

8344214: Remove Security Manager dependencies from jdk.crypto.mscapi module #22112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

seanjmullan
Copy link
Member

@seanjmullan seanjmullan commented Nov 14, 2024

Now that JEP 486 is integrated, the jdk.crypto.mscapi module implementation dependencies on System.getSecurityManager and AccessController.doPrivileged can be removed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344214: Remove Security Manager dependencies from jdk.crypto.mscapi module (Enhancement - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22112/head:pull/22112
$ git checkout pull/22112

Update a local copy of the PR:
$ git checkout pull/22112
$ git pull https://git.openjdk.org/jdk.git pull/22112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22112

View PR using the GUI difftool:
$ git pr show -t 22112

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22112.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 14, 2024

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 14, 2024

@seanjmullan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344214: Remove Security Manager dependencies from jdk.crypto.mscapi module

Reviewed-by: rriggs, ascarpino

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

  • ff12ff5: 8340453: C2: Improve encoding of LoadNKlass for compact headers
  • 1866c0c: 8344259: Annotate Float16 with jdk.internal.ValueBased
  • 0b9b82a: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io
  • 3c38ed4: 8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API
  • 40a055e: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration
  • 84ffb64: 8334714: Implement JEP 484: Class-File API
  • 6cdebf0: 8343599: Kmem limit and max values swapped when printing container information
  • a672138: 8344161: Argument type mismatch for jfr_type_id
  • 3245f56: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java
  • 5e27608: 8344188: Cleanup sun.net.www.protocol.jar.JarFileFactory after JEP 486 integration
  • ... and 21 more: https://git.openjdk.org/jdk/compare/68164a4847bc309a09701162528b4469660a58f0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 14, 2024
@openjdk
Copy link

openjdk bot commented Nov 14, 2024

@seanjmullan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Nov 14, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 14, 2024

Webrevs

Copy link
Contributor

@RogerRiggs RogerRiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 14, 2024
Copy link
Contributor

@ascarpino ascarpino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@seanjmullan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 15, 2024

Going to push as commit fc8fb34.
Since your change was applied there have been 31 commits pushed to the master branch:

  • ff12ff5: 8340453: C2: Improve encoding of LoadNKlass for compact headers
  • 1866c0c: 8344259: Annotate Float16 with jdk.internal.ValueBased
  • 0b9b82a: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io
  • 3c38ed4: 8344314: Revert removal of jdk.internal.java.PreviewFeature.CLASSFILE_API
  • 40a055e: 8344228: Revisit SecurityManager usage in java.net.http after JEP 486 integration
  • 84ffb64: 8334714: Implement JEP 484: Class-File API
  • 6cdebf0: 8343599: Kmem limit and max values swapped when printing container information
  • a672138: 8344161: Argument type mismatch for jfr_type_id
  • 3245f56: 8344164: [s390x] ProblemList hotspot/jtreg/runtime/NMT/VirtualAllocCommitMerge.java
  • 5e27608: 8344188: Cleanup sun.net.www.protocol.jar.JarFileFactory after JEP 486 integration
  • ... and 21 more: https://git.openjdk.org/jdk/compare/68164a4847bc309a09701162528b4469660a58f0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 15, 2024
@openjdk openjdk bot closed this Nov 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 15, 2024
@openjdk
Copy link

openjdk bot commented Nov 15, 2024

@seanjmullan Pushed as commit fc8fb34.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants