Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260327: Shenandoah: Shenandoah may fail with -XX:UseSSE=0 on x86_32 #2214

Closed
wants to merge 1 commit into from

Conversation

DamonFool
Copy link
Member

@DamonFool DamonFool commented Jan 25, 2021

Hi all,

I'd like to fix this bug although UseSSE=0 won't be used in product environments.
However, it will be benefit for our testing of OpenJDK.

The fix just following the style of RegisterSaver::save_live_registers [1].

Thanks.
Best regards,
Jie

[1] https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp#L205


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260327: Shenandoah: Shenandoah may fail with -XX:UseSSE=0 on x86_32

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2214/head:pull/2214
$ git checkout pull/2214

@DamonFool
Copy link
Member Author

/issue add JDK-8260327
/test
/label add hotspot-gc
/cc hotspot-gc

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2021

👋 Welcome back jiefu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 25, 2021
@openjdk
Copy link

openjdk bot commented Jan 25, 2021

@DamonFool This issue is referenced in the PR title - it will now be updated.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jan 25, 2021
@openjdk
Copy link

openjdk bot commented Jan 25, 2021

@DamonFool
The hotspot-gc label was successfully added.

@openjdk
Copy link

openjdk bot commented Jan 25, 2021

@DamonFool The hotspot-gc label was already applied.

@mlbridge
Copy link

mlbridge bot commented Jan 25, 2021

Webrevs

@rkennke
Copy link
Contributor

rkennke commented Jan 25, 2021

Hi @DamonFool,
we already have an ongoing PR about this:
#1172

Maybe coordinate with @shipilev which way to go? Not sure if Aleksey intends to take this any further.

@DamonFool
Copy link
Member Author

I didn't know that before.

Since you are the experts in Shenandoah, I'll close this PR.
Thanks.

@DamonFool DamonFool closed this Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants