Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260329: Update references to TAOCP to latest edition #2215

Closed
wants to merge 2 commits into from

Conversation

@jddarcy
Copy link
Member

@jddarcy jddarcy commented Jan 25, 2021

Updating and regularizing several references to Knuth's The Art of Computer Programming.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260329: Update references to TAOCP to latest edition

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2215/head:pull/2215
$ git checkout pull/2215

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 25, 2021

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Jan 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 25, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260329: Update references to TAOCP to latest edition

Reviewed-by: alanb, bpb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • 5b0b24b: 8260381: ProblemList com/sun/management/DiagnosticCommandMBean/DcmdMBeanTestCheckJni.java on Win with ZGC
  • 47c7dc7: 8258833: Cancel multi-part cipher operations in SunPKCS11 after failures
  • ef247ab: 8260308: Update LogCompilation junit to 4.13.1
  • d076977: 8260169: LogCompilation: Unexpected method mismatch
  • 6e03735: 8259845: Move placeholder implementation details to cpp file and add logging
  • ca20c63: 8259710: Inlining trace leaks memory
  • 09489e2: 8260338: Some fields in HaltNode is not cloned
  • af155fc: 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo
  • d825339: 8260263: Remove PtrQueue::_qset
  • 5898ab6: 8259894: refactor parts of jvm.h into jvm_io.h and jvm_constants.h
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/535c2927b6e0004ffa1ab5af3e19a622ab14d9f1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 25, 2021
@bplb
bplb approved these changes Jan 25, 2021
@jddarcy
Copy link
Member Author

@jddarcy jddarcy commented Jan 25, 2021

/integrate

@openjdk openjdk bot closed this Jan 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@jddarcy Since your change was applied there have been 13 commits pushed to the master branch:

  • 5b0b24b: 8260381: ProblemList com/sun/management/DiagnosticCommandMBean/DcmdMBeanTestCheckJni.java on Win with ZGC
  • 47c7dc7: 8258833: Cancel multi-part cipher operations in SunPKCS11 after failures
  • ef247ab: 8260308: Update LogCompilation junit to 4.13.1
  • d076977: 8260169: LogCompilation: Unexpected method mismatch
  • 6e03735: 8259845: Move placeholder implementation details to cpp file and add logging
  • ca20c63: 8259710: Inlining trace leaks memory
  • 09489e2: 8260338: Some fields in HaltNode is not cloned
  • af155fc: 8258836: JNI local refs exceed capacity getDiagnosticCommandInfo
  • d825339: 8260263: Remove PtrQueue::_qset
  • 5898ab6: 8259894: refactor parts of jvm.h into jvm_io.h and jvm_constants.h
  • ... and 3 more: https://git.openjdk.java.net/jdk/compare/535c2927b6e0004ffa1ab5af3e19a622ab14d9f1...master

Your commit was automatically rebased without conflicts.

Pushed as commit 73c78c8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jddarcy jddarcy deleted the jddarcy:8260329 branch Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants