Skip to content

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Nov 15, 2024

Move jpackage tests from "jdk.jpackage.tests" package to the default package.

Remove WindowsHelper.getTempDirectory(). It is faulty and found limited use. Updated dependent tests accordingly.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344326: Move jpackage tests from "jdk.jpackage.tests" package to the default package (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22156/head:pull/22156
$ git checkout pull/22156

Update a local copy of the PR:
$ git checkout pull/22156
$ git pull https://git.openjdk.org/jdk.git pull/22156/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22156

View PR using the GUI difftool:
$ git pr show -t 22156

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22156.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2024

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 15, 2024

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344326: Move jpackage tests from "jdk.jpackage.tests" package to the default package

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 62 new commits pushed to the master branch:

  • 41a2d49: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking
  • 276251c: 8342826: Improve performance of oopDesc::klass() after JDK-8305895
  • c388455: 8344197: SM cleanup in java.util.concurrent
  • c5b6ed8: 8344252: SM cleanup in java.util classes
  • 59ffac8: 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5
  • f316808: 8344189: Cleanup code in sun.net.www.protocol.mailto.MailToURLConnection and sun.net.smtp after JEP 486 integration
  • 73fd891: 8344216: Remove calls to SecurityManager and and doPrivileged in java.net.Authenticator, java.net.CookieHandler, and java.net.ResponseCache after JEP 486 integration
  • f62e05e: 8344231: SecurityManager cleanup in java.lang.module and jdk.internal.module
  • 1bb0d3b: 8344062: Remove doPrivileged calls from awt and beans classes in the java.desktop module
  • fc8fb34: 8344214: Remove Security Manager dependencies from jdk.crypto.mscapi module
  • ... and 52 more: https://git.openjdk.org/jdk/compare/95a00f8a188048952871a10dc428566b18b91cb8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 15, 2024

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 15, 2024
@alexeysemenyukoracle alexeysemenyukoracle marked this pull request as ready for review November 15, 2024 18:20
@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev ptal

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2024

Webrevs

Copy link
Member

@sashamatveev sashamatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 15, 2024
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 15, 2024

Going to push as commit 2c509a1.
Since your change was applied there have been 62 commits pushed to the master branch:

  • 41a2d49: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking
  • 276251c: 8342826: Improve performance of oopDesc::klass() after JDK-8305895
  • c388455: 8344197: SM cleanup in java.util.concurrent
  • c5b6ed8: 8344252: SM cleanup in java.util classes
  • 59ffac8: 8342811: java/net/httpclient/PlainProxyConnectionTest.java failed: Unexpected connection count: 5
  • f316808: 8344189: Cleanup code in sun.net.www.protocol.mailto.MailToURLConnection and sun.net.smtp after JEP 486 integration
  • 73fd891: 8344216: Remove calls to SecurityManager and and doPrivileged in java.net.Authenticator, java.net.CookieHandler, and java.net.ResponseCache after JEP 486 integration
  • f62e05e: 8344231: SecurityManager cleanup in java.lang.module and jdk.internal.module
  • 1bb0d3b: 8344062: Remove doPrivileged calls from awt and beans classes in the java.desktop module
  • fc8fb34: 8344214: Remove Security Manager dependencies from jdk.crypto.mscapi module
  • ... and 52 more: https://git.openjdk.org/jdk/compare/95a00f8a188048952871a10dc428566b18b91cb8...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 15, 2024
@openjdk openjdk bot closed this Nov 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 15, 2024
@openjdk
Copy link

openjdk bot commented Nov 15, 2024

@alexeysemenyukoracle Pushed as commit 2c509a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants