Skip to content

8316151: [macos14] ActionListenerCalledTwiceTest.java fails on macOS 14 #22182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Nov 17, 2024

Test was failing due to apple bug in version < 14.5 and is passing in latest..Tested in CI systems and all passed for several iterations, so removing from PL..


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316151: [macos14] ActionListenerCalledTwiceTest.java fails on macOS 14 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22182/head:pull/22182
$ git checkout pull/22182

Update a local copy of the PR:
$ git checkout pull/22182
$ git pull https://git.openjdk.org/jdk.git pull/22182/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22182

View PR using the GUI difftool:
$ git pr show -t 22182

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22182.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 17, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316151: [macos14] ActionListenerCalledTwiceTest.java fails on macOS 14

Reviewed-by: tr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 84 new commits pushed to the master branch:

  • a47d9ba: 8344349: Problemlist jdk/jfr/jvm/TestVirtualThreadExclusion.java before JDK-8344199 resolved
  • 80e37a9: 8344265: RISC-V: Remove unused function get_previous_sp_entry
  • e1c4b49: 8343237: Improve the copying of the available set of Currencies
  • 41a627b: 8343876: Enhancements to jpackage test lib
  • aa10ec7: 8343123: Nimbus: javax/swing/JInternalFrame/bug6726866.java does not have green undecorated window
  • fec0d1c: 8343777: Add since checker tests to Internationalisation modules
  • d0b770c: 8344289: SM cleanup in jdk.internal.util
  • a91d4c0: 8344233: Remove calls to SecurityManager and doPrivileged in java.net.ProxySelector and sun.net.spi.DefaultProxySelector after JEP 486 integration
  • d2e4b51: 8344186: Cleanup sun.net.www.MimeTable after JEP 486 integration
  • da40388: 8344315: Clean up sun.net.www.protocol.jrt.JavaRuntimeURLConnection after JEP 486 integration
  • ... and 74 more: https://git.openjdk.org/jdk/compare/a5f11b5f775be6c1d9593562ba65912261efdf52...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 17, 2024

@prsadhuk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@prsadhuk prsadhuk changed the title [macos14] ActionListenerCalledTwiceTest.java fails on macOS 14 8316151: [macos14] ActionListenerCalledTwiceTest.java fails on macOS 14 Nov 17, 2024
@prsadhuk
Copy link
Contributor Author

/label add client

@openjdk openjdk bot added rfr Pull request is ready for review client client-libs-dev@openjdk.org labels Nov 17, 2024
@openjdk
Copy link

openjdk bot commented Nov 17, 2024

@prsadhuk
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 17, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2024
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

Going to push as commit b6c2122.
Since your change was applied there have been 86 commits pushed to the master branch:

  • 543e355: 8344298: Test tools/sincechecker/modules/jdk.hotspot.agent/JdkHotspotAgentCheckSince.java fails on platforms without sa
  • 92b2631: 8327652: S390x: Implements SLP support
  • a47d9ba: 8344349: Problemlist jdk/jfr/jvm/TestVirtualThreadExclusion.java before JDK-8344199 resolved
  • 80e37a9: 8344265: RISC-V: Remove unused function get_previous_sp_entry
  • e1c4b49: 8343237: Improve the copying of the available set of Currencies
  • 41a627b: 8343876: Enhancements to jpackage test lib
  • aa10ec7: 8343123: Nimbus: javax/swing/JInternalFrame/bug6726866.java does not have green undecorated window
  • fec0d1c: 8343777: Add since checker tests to Internationalisation modules
  • d0b770c: 8344289: SM cleanup in jdk.internal.util
  • a91d4c0: 8344233: Remove calls to SecurityManager and doPrivileged in java.net.ProxySelector and sun.net.spi.DefaultProxySelector after JEP 486 integration
  • ... and 76 more: https://git.openjdk.org/jdk/compare/a5f11b5f775be6c1d9593562ba65912261efdf52...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2024
@openjdk openjdk bot closed this Nov 18, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2024
@openjdk
Copy link

openjdk bot commented Nov 18, 2024

@prsadhuk Pushed as commit b6c2122.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8316151 branch November 18, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants