Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253274: The CycleDMImagetest brokes the system #222

Closed
wants to merge 3 commits into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 17, 2020

The test checks all display modes reported by the OS.

Unfortunately on some test systems the switching from the low-resolution modes to the normal mode "takes a while", the system becomes broken while some other tests start to work.

The fix will limit the resolution of modes tested, it should be bigger than 800x600. Also, the test should try to properly clean up the system after completion.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/222/head:pull/222
$ git checkout pull/222

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 17, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@mrserb The following label will be automatically applied to this pull request: awt.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Sep 17, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2020

Webrevs

Copy link
Contributor

@prrace prrace left a comment

As discussed off-line, can we make the test wait 10 seconds before terminating to be (fairly) sure the "currentDM" mode has been restored.

@@ -297,7 +297,7 @@ public static void main(String args[]) throws Exception {
}
// delay a bit just to let the fullscreen window disposing complete
// before switching to next display
delay(4000);
delay(10000);
Copy link
Member Author

@mrserb mrserb Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will sleep long enough to let the display mode switch occur.

prrace
prrace approved these changes Sep 17, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2020

@mrserb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253274: The CycleDMImagetest brokes the system

Reviewed-by: prr
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 16 commits pushed to the master branch:

  • 2c3a37c: 8253314: precompiled.hpp missing from vmIntrinsics.cpp
  • d4269fd: 8253028: SA core file tests still time out on OSX with "java.io.IOException: App waiting timeout"
  • 6c3e483: 8253313: xmlstream.hpp missing from vmIntrinsics.cpp
  • 0a1dc50: 8253271: vm_version_x86.hpp should not include globals_extension.hpp
  • 1e39649: 8243066: Move VM_INTRINSICS_DO into its own vmIntrinsics.hpp file
  • 12dfe1c: 8253262: Allocate in DumpRegion is not thread safe
  • 3570f5a: 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length
  • 24765e4: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings
  • 81e2cf8: 8251397: NPE on ClassValue.ClassValueMap.cacheArray
  • cca3a26: 8252996: Thread safety problem in java.net.ProxySelector
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/b87a1599674b8a73f489330decf051d1be9e9fba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 2c3a37c6d7638dc1a3318d9c5309516a1edfb590.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 17, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 18, 2020

/integrate

@openjdk openjdk bot closed this Sep 18, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2020

@mrserb Since your change was applied there have been 16 commits pushed to the master branch:

  • 2c3a37c: 8253314: precompiled.hpp missing from vmIntrinsics.cpp
  • d4269fd: 8253028: SA core file tests still time out on OSX with "java.io.IOException: App waiting timeout"
  • 6c3e483: 8253313: xmlstream.hpp missing from vmIntrinsics.cpp
  • 0a1dc50: 8253271: vm_version_x86.hpp should not include globals_extension.hpp
  • 1e39649: 8243066: Move VM_INTRINSICS_DO into its own vmIntrinsics.hpp file
  • 12dfe1c: 8253262: Allocate in DumpRegion is not thread safe
  • 3570f5a: 8252041: G1: Fix incorrect uses of HeapRegionManager::max_length
  • 24765e4: 8253285: Some java/util/StringJoiner tests do not explicitly specify required -XX:+CompactStrings
  • 81e2cf8: 8251397: NPE on ClassValue.ClassValueMap.cacheArray
  • cca3a26: 8252996: Thread safety problem in java.net.ProxySelector
  • ... and 6 more: https://git.openjdk.java.net/jdk/compare/b87a1599674b8a73f489330decf051d1be9e9fba...master

Your commit was automatically rebased without conflicts.

Pushed as commit fd380d7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb mrserb deleted the JDK-8253274 branch Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants