Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails #2224

Closed
wants to merge 3 commits into from

Conversation

@fguallini
Copy link
Contributor

@fguallini fguallini commented Jan 25, 2021

Fixing manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java". It was not handling "weak algorithm" warning during jarsigner output verification


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2224/head:pull/2224
$ git checkout pull/2224

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 25, 2021

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@fguallini The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security label Jan 25, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 25, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jan 25, 2021

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 87 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jan 25, 2021
@haimaychao
Copy link
Contributor

@haimaychao haimaychao commented Jan 25, 2021

Looks good.

@haimaychao
Copy link
Contributor

@haimaychao haimaychao commented Jan 25, 2021

One comment: Add bug id to the changed test. Thanks.

Copy link
Contributor

@haimaychao haimaychao left a comment

Change copyright year to 2021

@fguallini
Copy link
Contributor Author

@fguallini fguallini commented Jan 26, 2021

Thanks for the review

@fguallini
Copy link
Contributor Author

@fguallini fguallini commented Jan 26, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jan 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2021

@fguallini
Your change (at version b116237) is now ready to be sponsored by a Committer.

@rhalade
Copy link
Member

@rhalade rhalade commented Jan 26, 2021

/reviewer credit hchao

@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2021

@rhalade Only the author (@fguallini) is allowed to issue the reviewer command.

@fguallini
Copy link
Contributor Author

@fguallini fguallini commented Jan 26, 2021

/reviewer credit @haimaychao

@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2021

@fguallini Reviewer hchao has already made an authenticated review of this PR, and does not need to be credited manually.

@rhalade
Copy link
Member

@rhalade rhalade commented Jan 26, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jan 26, 2021

@rhalade @fguallini Since your change was applied there have been 87 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 9f0a043.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants