Skip to content

Conversation

@kabutz
Copy link
Contributor

@kabutz kabutz commented Nov 19, 2024

See internal bug review 9077848

This is a very small unimportant mistake in the naming of the documentation that does not match the code.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344595: State transitions in internal VirtualThread comment needs to be updated (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22253/head:pull/22253
$ git checkout pull/22253

Update a local copy of the PR:
$ git checkout pull/22253
$ git pull https://git.openjdk.org/jdk.git pull/22253/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22253

View PR using the GUI difftool:
$ git pr show -t 22253

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22253.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 19, 2024

👋 Welcome back kabutz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 19, 2024

@kabutz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344595: State transitions in internal VirtualThread comment needs to be updated

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • 22a39dc: 8344064: Remove doPrivileged calls from print/imageio/media classes in the java.desktop module
  • 27fda0e: 8344578: Clean up left over java.security and sun.security imports in Swing classes
  • 080f1cc: 8289771: jpackage: ResourceEditor error when path is overly long on Windows
  • c4c6b1f: 8344562: Remove security manager dependency from module jdk.jdi
  • 9be8ac6: 8344239: runtime/cds/appcds/jigsaw/addmods/AddmodsOption.java fails on x64 with -Xmixed
  • 7d4c3fd: 8331295: C2: Do not clone address computations that are indirect memory input to at least one load/store
  • 75420e9: 8334431: C2 SuperWord: fix performance regression due to store-to-load-forwarding failures
  • e11d126: 8333796: Add missing serialization functionality to sun.reflect.ReflectionFactory
  • 21f0ed5: 8344215: Remove calls to SecurityManager and doPrivileged in java.net.Socket and java.net.ServerSocket after JEP 486 integration
  • 4bc826a: 8342785: XWindowPeer::getNewLocation() adheres to ICCCM 4.1.5 only with some WMs
  • ... and 22 more: https://git.openjdk.org/jdk/compare/3328b4ecf225f95edfce6ab848dcfb62ddc1aaff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Nov 19, 2024

@kabutz The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 19, 2024
@kabutz kabutz changed the title Made documentation match state field names WAIT and TIMED_WAIT 8344595: Made documentation match state field names WAIT and TIMED_WAIT Nov 20, 2024
@kabutz kabutz changed the title 8344595: Made documentation match state field names WAIT and TIMED_WAIT 8344595: Naming incorrect for WAIT state in VirtualThread documentation Nov 20, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2024

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this comment was missed in the loom repo when we did the last rename.

You'll need to adjust the PR title to match the JBS issue before integrating.

@kabutz kabutz changed the title 8344595: Naming incorrect for WAIT state in VirtualThread documentation 8344595: State transitions in internal VirtualThread comment needs to be updated Nov 20, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 20, 2024
@kabutz
Copy link
Contributor Author

kabutz commented Nov 20, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@kabutz
Your change (at version 2817981) is now ready to be sponsored by a Committer.

@AlanBateman
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

Going to push as commit da2d7a0.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 22a39dc: 8344064: Remove doPrivileged calls from print/imageio/media classes in the java.desktop module
  • 27fda0e: 8344578: Clean up left over java.security and sun.security imports in Swing classes
  • 080f1cc: 8289771: jpackage: ResourceEditor error when path is overly long on Windows
  • c4c6b1f: 8344562: Remove security manager dependency from module jdk.jdi
  • 9be8ac6: 8344239: runtime/cds/appcds/jigsaw/addmods/AddmodsOption.java fails on x64 with -Xmixed
  • 7d4c3fd: 8331295: C2: Do not clone address computations that are indirect memory input to at least one load/store
  • 75420e9: 8334431: C2 SuperWord: fix performance regression due to store-to-load-forwarding failures
  • e11d126: 8333796: Add missing serialization functionality to sun.reflect.ReflectionFactory
  • 21f0ed5: 8344215: Remove calls to SecurityManager and doPrivileged in java.net.Socket and java.net.ServerSocket after JEP 486 integration
  • 4bc826a: 8342785: XWindowPeer::getNewLocation() adheres to ICCCM 4.1.5 only with some WMs
  • ... and 22 more: https://git.openjdk.org/jdk/compare/3328b4ecf225f95edfce6ab848dcfb62ddc1aaff...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 20, 2024
@openjdk openjdk bot closed this Nov 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@AlanBateman @kabutz Pushed as commit da2d7a0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kabutz kabutz deleted the state-names-not-matching branch November 22, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants