-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8344595: State transitions in internal VirtualThread comment needs to be updated #22253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back kabutz! A progress list of the required criteria for merging this PR into |
|
@kabutz This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 32 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@AlanBateman) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
AlanBateman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this comment was missed in the loom repo when we did the last rename.
You'll need to adjust the PR title to match the JBS issue before integrating.
|
/integrate |
|
/sponsor |
|
Going to push as commit da2d7a0.
Your commit was automatically rebased without conflicts. |
|
@AlanBateman @kabutz Pushed as commit da2d7a0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
See internal bug review 9077848
This is a very small unimportant mistake in the naming of the documentation that does not match the code.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22253/head:pull/22253$ git checkout pull/22253Update a local copy of the PR:
$ git checkout pull/22253$ git pull https://git.openjdk.org/jdk.git pull/22253/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22253View PR using the GUI difftool:
$ git pr show -t 22253Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22253.diff
Using Webrev
Link to Webrev Comment