8344479: Declare MetaspaceObj::operator delete to be deleted

[coleenp]

Please review this trivial change to delete the MetaspaceObj::operator delete method.

Sanity tested with tier1 on supported platforms.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344479: Declare MetaspaceObj::operator delete to be deleted (Enhancement - P4)

Reviewers

• Stefan Karlsson (@stefank - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22259/head:pull/22259
$ git checkout pull/22259

Update a local copy of the PR:
$ git checkout pull/22259
$ git pull https://git.openjdk.org/jdk.git pull/22259/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22259

View PR using the GUI difftool:
$ git pr show -t 22259

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22259.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344479: Declare MetaspaceObj::operator delete to be deleted

Reviewed-by: stefank, kbarrett, jwaters

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 189fc8d: 8344381: [s390x] Test failures with error: Register type is not known
• 8a1f9f0: 8343476: Remove unnecessary @SuppressWarnings annotations (client)
• 4ddd3de: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize
• bc7eabd: 8344350: Add '.gdbinit' and '.lldbinit' to file '.gitignore'
• f525290: 8341935: javac states that -proc:full is the default but the default as of 23 is -proc:none
• acdbf83: 8341553: Remove UseCompactObjectHeaders extra CDS archives
• 81e4311: 8344077: Remove security manager dependency in java.io
• f6f73ce: 8344446: Remove security manager dependency from module jdk.sctp
• aac1f9a: 8341793: Fix ExceptionOccurred in jdk.accessibility
• cd45ba3: 8342041: Test gc/shenandoah/oom/TestClassLoaderLeak.java slow on Windows after JDK-8340490
• ... and 2 more: https://git.openjdk.org/jdk/compare/6a5256ec042e16a2157475e86e7859b345a91bd0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (dbf24eed)

[kimbarrett]

Looks good, and trivial.

[coleenp]

Thanks for the reviews, Stefan, Kim and Julian.
/integrate

[openjdk]

Going to push as commit 21b8749.
Since your change was applied there have been 19 commits pushed to the master branch:

• ea7e722: 8344010: RISC-V: Zacas do not work with LW locking
• e2f8f1a: 8344621: ProblemList runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java
• afee740: 8343541: C1: Plain memory accesses are emitted with membars with +AlwaysAtomicAccesses
• 3a4a9b7: 8340145: Problem with generic pattern matching results in internal compiler error
• cf158bc: 8341631: JShell should auto-import java.io.IO.*
• 5b12a87: 8344060: Remove doPrivileged calls from shared implementation code in the java.desktop module : part 1
• 587f2b4: 8343827: RISC-V: set AlignVector as false if applicable to enable SLP
• 189fc8d: 8344381: [s390x] Test failures with error: Register type is not known
• 8a1f9f0: 8343476: Remove unnecessary @SuppressWarnings annotations (client)
• 4ddd3de: 8344356: Aarch64: implement -XX:+VerifyActivationFrameSize
• ... and 9 more: https://git.openjdk.org/jdk/compare/6a5256ec042e16a2157475e86e7859b345a91bd0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 21b8749.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[coleenp]

Also, Kim, thanks for noticing this and filing the bug.