Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259809: Remove PerfEvent class loading locking counters #2227

Closed
wants to merge 1 commit into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Jan 25, 2021

See CR for details.
Tested with tier1-3.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259809: Remove PerfEvent class loading locking counters

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2227/head:pull/2227
$ git checkout pull/2227

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2021

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 25, 2021
@openjdk
Copy link

openjdk bot commented Jan 25, 2021

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 25, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2021

Webrevs

Copy link
Member

@cl4es cl4es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@openjdk
Copy link

openjdk bot commented Jan 25, 2021

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259809: Remove PerfEvent class loading locking counters

Reviewed-by: redestad, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 982e42b: 8259726: Use of HashSet leads to undefined order in test output
  • d6fb9d7: 8255464: Cannot access ModuleTree in a CompilationUnitTree

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 25, 2021
Copy link
Member

@iklam iklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to remove code that isn't useful/used anymore.

@coleenp
Copy link
Contributor Author

coleenp commented Jan 26, 2021

Thanks Claes and Ioi!
/integrate

@openjdk openjdk bot closed this Jan 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 26, 2021
@openjdk
Copy link

openjdk bot commented Jan 26, 2021

@coleenp Since your change was applied there have been 7 commits pushed to the master branch:

  • b4ace3e: 8260042: G1 Post-cleanup liveness printing occurs too early
  • 23edb6f: 8236490: Compiler bug relating to @nonnull annotation
  • abd9310: 8260222: remove unused _thread member SymbolTableLookup
  • c538cd8: 8165276: Spec states to invoke the premain method in an agent class if it's public but implementation differs
  • 9ea9323: 8254246: SymbolHashMapEntry wastes space
  • 982e42b: 8259726: Use of HashSet leads to undefined order in test output
  • d6fb9d7: 8255464: Cannot access ModuleTree in a CompilationUnitTree

Your commit was automatically rebased without conflicts.

Pushed as commit 81a66df.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the class-stat branch January 26, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
3 participants