Skip to content

Conversation

@coleenp
Copy link
Contributor

@coleenp coleenp commented Jan 25, 2021

The ConstantPool SymbolHashMapEntry is used by class file reconstitution, so the little wasted space doesn't make a difference, but it's fixed here. Tested with tier1 and vmTestbase/nsk/{jdi,jvmti} tests. Should be trivial.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2228/head:pull/2228
$ git checkout pull/2228

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 25, 2021

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 25, 2021
@openjdk
Copy link

openjdk bot commented Jan 25, 2021

@coleenp The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jan 25, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 25, 2021

Webrevs

Copy link
Member

@cl4es cl4es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk
Copy link

openjdk bot commented Jan 25, 2021

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8254246: SymbolHashMapEntry wastes space

Reviewed-by: redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 982e42b: 8259726: Use of HashSet leads to undefined order in test output
  • d6fb9d7: 8255464: Cannot access ModuleTree in a CompilationUnitTree

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 25, 2021
@coleenp
Copy link
Contributor Author

coleenp commented Jan 25, 2021

Thanks Claes!
/integrate

@openjdk openjdk bot closed this Jan 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 25, 2021
@openjdk
Copy link

openjdk bot commented Jan 25, 2021

@coleenp Since your change was applied there have been 2 commits pushed to the master branch:

  • 982e42b: 8259726: Use of HashSet leads to undefined order in test output
  • d6fb9d7: 8255464: Cannot access ModuleTree in a CompilationUnitTree

Your commit was automatically rebased without conflicts.

Pushed as commit 9ea9323.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the symhash branch January 25, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants