Skip to content

Conversation

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Nov 20, 2024

In JDK 16 we deprecated the old signal and sigset signal-chaining interfaces under JDK-8257572. The deprecation warning was written to stdout but all other warnings go to stderr. Having the warning be on stdout causes interference with application output so we change it to stderr.

Testing

  • examined signal test output (see JBS issue)
  • tiers 1-3 sanity

Thanks


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344646: The libjsig deprecation warning should go to stderr not stdout (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22283/head:pull/22283
$ git checkout pull/22283

Update a local copy of the PR:
$ git checkout pull/22283
$ git pull https://git.openjdk.org/jdk.git pull/22283/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22283

View PR using the GUI difftool:
$ git pr show -t 22283

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22283.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2024

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344646: The libjsig deprecation warning should go to stderr not stdout

Reviewed-by: mikael, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 882d635: 8245545: Disable TLS_RSA cipher suites
  • 8f22db2: 8330606: Redefinition doesn't but should verify the new klass
  • a62279c: 8344235: Revisit SecurityManager usage in java.logging after JEP 486 and JEP 491 integration
  • 18df6fd: 8336707: Contention of ForkJoinPool grows when stealing works
  • f2b10c6: 8340422: ZGC: TestAllocateHeapAt.java should not run with transparent hugepages
  • 5ccd510: 8326369: Add test to verify bimorphic inlining happens after morphism changes
  • 93aa7e2: 8328085: C2: Use after free in PhaseChaitin::Register_Allocate()
  • 10def48: 8344236: Revisit SecurityManager usage in jdk.net after JEP 486 integration
  • 7105bb9: 8344664: Remove some un-used java/sun.security imports in the java.desktop module
  • a01aa22: 8342281: Deprecate for removal javax.sound.sampled.AudioPermission
  • ... and 23 more: https://git.openjdk.org/jdk/compare/3a4a9b7af7693a836c3caa3112d0d68100535b28...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@dholmes-ora The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 20, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2024

Webrevs

@dholmes-ora
Copy link
Member Author

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 20, 2024
@openjdk
Copy link

openjdk bot commented Nov 20, 2024

@dholmes-ora
The hotspot-runtime label was successfully added.

@dholmes-ora
Copy link
Member Author

Thanks for the review @vidmik !

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 20, 2024
@dholmes-ora
Copy link
Member Author

Thanks for the review @plummercj !

I will wait the ~24 hours then integrate.

@dholmes-ora
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

Going to push as commit efeacfe.
Since your change was applied there have been 49 commits pushed to the master branch:

  • 2214906: 8272339: Update notes section from serialver man page
  • cee74f9: 8338536: Permanently disable remote code downloading in JNDI
  • 7709d43: 8344782: Cleanup left over doPrivileged calls and imports in java.desktop
  • e03b150: 8178966: Don't swallow early bootstrap exceptions in Boolean.getBoolean, Integer.getInteger and Long.getLong
  • d6b40d3: 8344144: AES/CBC slow at big payloads
  • 93d4ad4: 8344763: cpCache print_on doesn't handle nulls
  • dc9a6ef: 8341137: Optimize long vector multiplication using x86 VPMUL[U]DQ instruction
  • 191b38e: 8344549: Cleanup AccessController in sun.misc.Unsafe
  • 78e5008: 8317542: Specjvm::xml have scalability issue for high vCPU numbers
  • 4956a76: 8317538: Potential bottleneck in Provider::getService: specjvm2008::crypto.rsa have scalability issue for high vCPU numbers
  • ... and 39 more: https://git.openjdk.org/jdk/compare/3a4a9b7af7693a836c3caa3112d0d68100535b28...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2024
@openjdk openjdk bot closed this Nov 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2024
@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@dholmes-ora Pushed as commit efeacfe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8344646-jsig branch July 10, 2025 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants