-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8344646: The libjsig deprecation warning should go to stderr not stdout #22283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into |
|
@dholmes-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 33 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@dholmes-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
|
/label add hotspot-runtime |
|
@dholmes-ora |
|
Thanks for the review @vidmik ! |
|
Thanks for the review @plummercj ! I will wait the ~24 hours then integrate. |
|
/integrate |
|
Going to push as commit efeacfe.
Your commit was automatically rebased without conflicts. |
|
@dholmes-ora Pushed as commit efeacfe. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
In JDK 16 we deprecated the old signal and sigset signal-chaining interfaces under JDK-8257572. The deprecation warning was written to stdout but all other warnings go to stderr. Having the warning be on stdout causes interference with application output so we change it to stderr.
Testing
Thanks
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22283/head:pull/22283$ git checkout pull/22283Update a local copy of the PR:
$ git checkout pull/22283$ git pull https://git.openjdk.org/jdk.git pull/22283/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22283View PR using the GUI difftool:
$ git pr show -t 22283Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22283.diff
Using Webrev
Link to Webrev Comment