8342281: Deprecate for removal javax.sound.sampled.AudioPermission

[prrace]

Deprecate AudioPermission for removal.

I found a test that uses it and updated it.

The CSR needs to be reviewed too : https://bugs.openjdk.org/browse/JDK-8344658

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Change requires CSR request JDK-8344658 to be approved
• Commit message must refer to an issue

Issues

• JDK-8342281: Deprecate for removal javax.sound.sampled.AudioPermission (Bug - P4)
• JDK-8344658: Deprecate for removal javax.sound.sampled.AudioPermission (CSR)

Reviewers

• Harshitha Onkar (@honkar-jdk - Reviewer)
• Alexander Zuev (@azuev-java - Reviewer) Review applies to 2e9e4ec2

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22284/head:pull/22284
$ git checkout pull/22284

Update a local copy of the PR:
$ git checkout pull/22284
$ git pull https://git.openjdk.org/jdk.git pull/22284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22284

View PR using the GUI difftool:
$ git pr show -t 22284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22284.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342281: Deprecate for removal javax.sound.sampled.AudioPermission

Reviewed-by: honkar, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[prrace]

/csr

[openjdk]

@prrace an approved CSR request is already required for this pull request.

[openjdk]

@prrace The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2bd5c41d)
• 00: Full (2e9e4ec2)

[honkar-jdk]

Changes LGTM except for the SecurityException catch block removal in the test.

[honkar-jdk]

Minor:
These are on unchanged lines.
Since AudioSystem.getLine(infos[0]) no longer throws security exception, the SecurityException catch block can be removed.

    try {
        l = AudioSystem.getLine(infos[0]);
    } catch(SecurityException lue) {
        log.println("SecurityException");
        return STATUS_PASSED;
    }

[prrace]

Minor: These are on unchanged lines. Since AudioSystem.getLine(infos[0]) no longer throws security exception, the SecurityException catch block can be removed.

    try {
        l = AudioSystem.getLine(infos[0]);
    } catch(SecurityException lue) {
        log.println("SecurityException");
        return STATUS_PASSED;
    }

Good catch. It was so far out of sight I missed that. I've removed it.

[azuev-java]

Looks good.

[prrace]

/integrate

[openjdk]

Going to push as commit a01aa22.
Since your change was applied there have been 4 commits pushed to the master branch:

• 4fbf272: 8344526: RISC-V: implement -XX:+VerifyActivationFrameSize
• 1343911: 8340334: Update jcmd VM.events max parameter to be INT
• 400eb9b: 8344524: Remove SecurityManager related code from jdk.jlink module
• a599c30: 8344471: Remove SecurityManager related code from java.compiler module

Your commit was automatically rebased without conflicts.

[openjdk]

@prrace Pushed as commit a01aa22.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.