8344763: cpCache print_on doesn't handle nulls

[coleenp]

A change to remove some more security manager code, resulted in java.lang.System not having any more indy instructions so the gtest test_cpCache_output.cpp was crashing because of missing null checks. Please review this trivial change to add in null checks. The test doesn't verify that there are indys so doesn't need to be fixed.

Tested with gtest and upcoming security manager change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344763: cpCache print_on doesn't handle nulls (Bug - P4)

Reviewers

• Matias Saavedra Silva (@matias9927 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22298/head:pull/22298
$ git checkout pull/22298

Update a local copy of the PR:
$ git checkout pull/22298
$ git pull https://git.openjdk.org/jdk.git pull/22298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22298

View PR using the GUI difftool:
$ git pr show -t 22298

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22298.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344763: cpCache print_on doesn't handle nulls

Reviewed-by: matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 191b38e: 8344549: Cleanup AccessController in sun.misc.Unsafe
• 78e5008: 8317542: Specjvm::xml have scalability issue for high vCPU numbers
• 4956a76: 8317538: Potential bottleneck in Provider::getService: specjvm2008::crypto.rsa have scalability issue for high vCPU numbers
• 6113fa7: 8344248: Remove Security Manager dependencies from java.security.jgss and jdk.security.jgss modules
• 395e404: 8344066: Remove SecurityManager uses from the jdk.accessibility module
• dfa18fe: 8344328: (dc) DatagramChannelImpl.blockingReceive can now synchronize on packet
• 87be63f: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio
• aaf3df7: 8343823: (fs) Files.createLink: inconsistent behavior when creating link to symbolic link
• eef1561: 8344569: SwingUtilities2.makeIcon_Unprivileged is obsolete

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[matias9927]

Looks good, thanks!

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1c567e27)

[coleenp]

Thanks Matias!
/integrate

[openjdk]

Going to push as commit 93d4ad4.
Since your change was applied there have been 10 commits pushed to the master branch:

• dc9a6ef: 8341137: Optimize long vector multiplication using x86 VPMUL[U]DQ instruction
• 191b38e: 8344549: Cleanup AccessController in sun.misc.Unsafe
• 78e5008: 8317542: Specjvm::xml have scalability issue for high vCPU numbers
• 4956a76: 8317538: Potential bottleneck in Provider::getService: specjvm2008::crypto.rsa have scalability issue for high vCPU numbers
• 6113fa7: 8344248: Remove Security Manager dependencies from java.security.jgss and jdk.security.jgss modules
• 395e404: 8344066: Remove SecurityManager uses from the jdk.accessibility module
• dfa18fe: 8344328: (dc) DatagramChannelImpl.blockingReceive can now synchronize on packet
• 87be63f: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio
• aaf3df7: 8343823: (fs) Files.createLink: inconsistent behavior when creating link to symbolic link
• eef1561: 8344569: SwingUtilities2.makeIcon_Unprivileged is obsolete

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 93d4ad4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.