Skip to content

8344782: Cleanup left over doPrivileged calls and imports in java.desktop #22306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

prrace
Copy link
Contributor

@prrace prrace commented Nov 21, 2024

Some clean up of left overs


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344782: Cleanup left over doPrivileged calls and imports in java.desktop (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22306/head:pull/22306
$ git checkout pull/22306

Update a local copy of the PR:
$ git checkout pull/22306
$ git pull https://git.openjdk.org/jdk.git pull/22306/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22306

View PR using the GUI difftool:
$ git pr show -t 22306

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22306.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2024

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344782: Cleanup left over doPrivileged calls and imports in java.desktop

Reviewed-by: honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • d6b40d3: 8344144: AES/CBC slow at big payloads
  • 93d4ad4: 8344763: cpCache print_on doesn't handle nulls
  • dc9a6ef: 8341137: Optimize long vector multiplication using x86 VPMUL[U]DQ instruction
  • 191b38e: 8344549: Cleanup AccessController in sun.misc.Unsafe
  • 78e5008: 8317542: Specjvm::xml have scalability issue for high vCPU numbers
  • 4956a76: 8317538: Potential bottleneck in Provider::getService: specjvm2008::crypto.rsa have scalability issue for high vCPU numbers
  • 6113fa7: 8344248: Remove Security Manager dependencies from java.security.jgss and jdk.security.jgss modules
  • 395e404: 8344066: Remove SecurityManager uses from the jdk.accessibility module
  • dfa18fe: 8344328: (dc) DatagramChannelImpl.blockingReceive can now synchronize on packet
  • 87be63f: 8344659: Some uses of GetPropertyAction were not removed from java.io and java.nio
  • ... and 1 more: https://git.openjdk.org/jdk/compare/eef156180c772a042416fc35d86072e722519f0b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8344782 8344782: Cleanup left over doPrivileged calls and imports in java.desktop Nov 21, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2024
@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@prrace The following labels will be automatically applied to this pull request:

  • client
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added client client-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Nov 21, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2024

Webrevs

Copy link
Contributor

@honkar-jdk honkar-jdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 21, 2024
@prrace
Copy link
Contributor Author

prrace commented Nov 21, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2024

Going to push as commit 7709d43.
Since your change was applied there have been 12 commits pushed to the master branch:

  • e03b150: 8178966: Don't swallow early bootstrap exceptions in Boolean.getBoolean, Integer.getInteger and Long.getLong
  • d6b40d3: 8344144: AES/CBC slow at big payloads
  • 93d4ad4: 8344763: cpCache print_on doesn't handle nulls
  • dc9a6ef: 8341137: Optimize long vector multiplication using x86 VPMUL[U]DQ instruction
  • 191b38e: 8344549: Cleanup AccessController in sun.misc.Unsafe
  • 78e5008: 8317542: Specjvm::xml have scalability issue for high vCPU numbers
  • 4956a76: 8317538: Potential bottleneck in Provider::getService: specjvm2008::crypto.rsa have scalability issue for high vCPU numbers
  • 6113fa7: 8344248: Remove Security Manager dependencies from java.security.jgss and jdk.security.jgss modules
  • 395e404: 8344066: Remove SecurityManager uses from the jdk.accessibility module
  • dfa18fe: 8344328: (dc) DatagramChannelImpl.blockingReceive can now synchronize on packet
  • ... and 2 more: https://git.openjdk.org/jdk/compare/eef156180c772a042416fc35d86072e722519f0b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2024
@openjdk openjdk bot closed this Nov 21, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2024
@openjdk
Copy link

openjdk bot commented Nov 21, 2024

@prrace Pushed as commit 7709d43.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants