Skip to content

8344830: [BACKOUT] JDK-8341334: CDS: Parallel relocation #22314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 22, 2024

This caused failures in higher tier testing. We are backing this out to figure test failures out without blocking testing. This also backs out related ProblemList additions: JDK-8344621. Both are clean git revert-s.

Additional testing:

  • Linux x86_64 server fastdebug, runtime/cds

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344830: [BACKOUT] JDK-8341334: CDS: Parallel relocation (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22314/head:pull/22314
$ git checkout pull/22314

Update a local copy of the PR:
$ git checkout pull/22314
$ git pull https://git.openjdk.org/jdk.git pull/22314/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22314

View PR using the GUI difftool:
$ git pr show -t 22314

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22314.diff

Using Webrev

Link to Webrev Comment

@shipilev
Copy link
Member Author

@dholmes-ora ^

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344830: [BACKOUT] JDK-8341334: CDS: Parallel relocation

Reviewed-by: dholmes, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 56 new commits pushed to the master branch:

  • bf374c3: 8343453: Modernize FloatingDecimal tests
  • 847f65c: 8344844: ciReplay tests fail with -XX:+UseCompactObjectHeaders because CDS is disabled since JDK-8341553
  • 8903854: 8344718: Test runtime/cds/appcds/jigsaw/addmods/AddmodsOption.java fails on Linuxppc64le after JDK-8344239
  • a07b72b: 8344346: java/net/httpclient/ShutdownNow.java fails with java.lang.AssertionError: client was still running, but exited after further delay: timeout should be adjusted
  • 2ea0364: 8343893: Test jdk/jfr/event/runtime/TestNativeMemoryUsageEvents.java failed: heap should have grown and NMT should show that: expected 0 > 0
  • 50c099d: 8344799: Remove permissions checks from java.awt.Desktop
  • e21d06f: 8344338: javax/swing/JTextArea/bug4265784.java fails on Ubuntu 24.04.1
  • db44e97: 8344798: Shenandoah: Use more descriptive variable names in shPhaseTimings.cpp
  • c199f53: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker
  • 0f458e2: 8342903: Deprecate for removal java.awt.Window.getWarningString()
  • ... and 46 more: https://git.openjdk.org/jdk/compare/21b8749bfdede7dfee3e8433dd9443320db99076...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 22, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2024

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backout looks good.

Thanks for doing this. We can revisit next week.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 22, 2024
@shipilev
Copy link
Member Author

Thanks. Trivial, right?

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified that this backout merely reverts the original changes done for the following two issues:

https://bugs.openjdk.org/browse/JDK-8341334
https://bugs.openjdk.org/browse/JDK-8344621

Looks good to me.

@shipilev
Copy link
Member Author

@jaikiran, you think this is trivial, right? I need this ack to integrate without waiting for 24 hours.

@jaikiran
Copy link
Member

jaikiran commented Nov 22, 2024

@shipilev, I believe it's trivial, yes. Plus this addresses the test failures that we have noticed in our CI.

@shipilev
Copy link
Member Author

OK, good. I am integrating then.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

Going to push as commit 82c3612.
Since your change was applied there have been 57 commits pushed to the master branch:

  • 64e4aa2: 8339916: AIOOBE due to Math.abs(Integer.MIN_VALUE) in tests
  • bf374c3: 8343453: Modernize FloatingDecimal tests
  • 847f65c: 8344844: ciReplay tests fail with -XX:+UseCompactObjectHeaders because CDS is disabled since JDK-8341553
  • 8903854: 8344718: Test runtime/cds/appcds/jigsaw/addmods/AddmodsOption.java fails on Linuxppc64le after JDK-8344239
  • a07b72b: 8344346: java/net/httpclient/ShutdownNow.java fails with java.lang.AssertionError: client was still running, but exited after further delay: timeout should be adjusted
  • 2ea0364: 8343893: Test jdk/jfr/event/runtime/TestNativeMemoryUsageEvents.java failed: heap should have grown and NMT should show that: expected 0 > 0
  • 50c099d: 8344799: Remove permissions checks from java.awt.Desktop
  • e21d06f: 8344338: javax/swing/JTextArea/bug4265784.java fails on Ubuntu 24.04.1
  • db44e97: 8344798: Shenandoah: Use more descriptive variable names in shPhaseTimings.cpp
  • c199f53: 8344336: SM cleanup of java.lang.System, Runtime, String, StackWalker
  • ... and 47 more: https://git.openjdk.org/jdk/compare/21b8749bfdede7dfee3e8433dd9443320db99076...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2024
@openjdk openjdk bot closed this Nov 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@shipilev Pushed as commit 82c3612.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora
Copy link
Member

@shipilev Backout PRs are considered trivial

https://openjdk.org/guide/#backing-out-a-change

@shipilev shipilev deleted the JDK-8344830-cds-backout branch January 8, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants