-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8344830: [BACKOUT] JDK-8341334: CDS: Parallel relocation #22314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 56 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backout looks good.
Thanks for doing this. We can revisit next week.
Thanks. Trivial, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified that this backout merely reverts the original changes done for the following two issues:
https://bugs.openjdk.org/browse/JDK-8341334
https://bugs.openjdk.org/browse/JDK-8344621
Looks good to me.
@jaikiran, you think this is trivial, right? I need this ack to integrate without waiting for 24 hours. |
@shipilev, I believe it's trivial, yes. Plus this addresses the test failures that we have noticed in our CI. |
OK, good. I am integrating then. /integrate |
Going to push as commit 82c3612.
Your commit was automatically rebased without conflicts. |
@shipilev Backout PRs are considered trivial |
This caused failures in higher tier testing. We are backing this out to figure test failures out without blocking testing. This also backs out related ProblemList additions: JDK-8344621. Both are clean
git revert
-s.Additional testing:
runtime/cds
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22314/head:pull/22314
$ git checkout pull/22314
Update a local copy of the PR:
$ git checkout pull/22314
$ git pull https://git.openjdk.org/jdk.git pull/22314/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22314
View PR using the GUI difftool:
$ git pr show -t 22314
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22314.diff
Using Webrev
Link to Webrev Comment