JDK-8260404: jvm_io.h include missing in a number of files

[tstuefe]

One of the last include corrections caused a build error on our AIX machines because compile.cpp uses jio_snprintf() without including jvm_io.h.

I did not deeply follow up on the why, but "8260307: Do not include method.hpp in frame.hpp" is a possible candidate. AIX builds without JFR and hence miss a number of include chains other platforms have.

I scanned hotspot sources for files using jio_snprintf but not including jvm_io.h. There are some hits, which should be fixed.

All this is trivial, right?

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260404: jvm_io.h include missing in a number of files

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)
• Ioi Lam (@iklam - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2232/head:pull/2232
$ git checkout pull/2232

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[shipilev]

Ah. I saw x86_32 build failures as well, so I PR'ed #2237. I think you linked this issue incorrectly to JDK-8260404, not JDK-8259894, and that is why I missed it. If you are about to propose this PR, I can close mine as duplicate.

[tstuefe]

Ah. I saw x86_32 build failures as well, so I PR'ed #2237. I think you linked this issue incorrectly to JDK-8260404, not JDK-8259894, and that is why I missed it. If you are about to propose this PR, I can close mine as duplicate.

Sorry, I saw this too late. I am fine with either PR.

[mlbridge]

Webrevs

• 00: Full (ca8c727)

[shipilev]

Looks fine to me.

(And your fix is more comprehensive, I'll close mine as duplicate)

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260404: jvm_io.h include missing in a number of files

Reviewed-by: shade, iklam, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• c836da3: 8252412: [macos11] system dynamic libraries removed from filesystem
• e1411fd: 6606673: Path2D.Double, Path2D.Float and GeneralPath ctors throw exception when initialCapacity is negative
• 6f2be9c: 8246112: Remove build-time and run-time checks for clock_gettime and CLOCK_MONOTONIC
• 19b6f61: 8260334: Remove deprecated sv_for_node_id() from Compile
• 1bebd41: 8260421: Shenandoah: Fix conc_mark_roots timing name and indentations
• 42cef27: 8260343: Delete obsolete classes in the Windows L&F
• 9f0a043: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails
• fd00ed7: 8256298: Shenandoah: Enable concurrent stack processing
• b07797c: 8260391: Remove StringCoding::err
• af8a08f: 8260378: [TESTBUG] DcmdMBeanTestCheckJni.java reports false positive
• ... and 7 more: https://git.openjdk.java.net/jdk/compare/abd9310bff31b5fc1677ab02609641ecc8faf356...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[dholmes-ora]

Hi Thomas,

This all seems okay.

Thanks,
David

[tstuefe]

Thanks Alexey, Ioi and David!

/integrate

[openjdk]

@tstuefe Since your change was applied there have been 18 commits pushed to the master branch:

• bd2744d: 8260106: Shenandoah: refactor reference updating closures and related code
• c836da3: 8252412: [macos11] system dynamic libraries removed from filesystem
• e1411fd: 6606673: Path2D.Double, Path2D.Float and GeneralPath ctors throw exception when initialCapacity is negative
• 6f2be9c: 8246112: Remove build-time and run-time checks for clock_gettime and CLOCK_MONOTONIC
• 19b6f61: 8260334: Remove deprecated sv_for_node_id() from Compile
• 1bebd41: 8260421: Shenandoah: Fix conc_mark_roots timing name and indentations
• 42cef27: 8260343: Delete obsolete classes in the Windows L&F
• 9f0a043: 8260286: Manual Test "ws/open/test/jdk/sun/security/tools/jarsigner/compatibility/Compatibility.java" fails
• fd00ed7: 8256298: Shenandoah: Enable concurrent stack processing
• b07797c: 8260391: Remove StringCoding::err
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/abd9310bff31b5fc1677ab02609641ecc8faf356...master

Your commit was automatically rebased without conflicts.

Pushed as commit 1c77046.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.