Skip to content

8344867: Cleanup unneeded qualified exports to java.rmi #22329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Nov 22, 2024

java.base has a few exports to java.rmi that are no longer needed.
sun.security.util, sun.security.provider, and sun.reflect.misc.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344867: Cleanup unneeded qualified exports to java.rmi (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22329/head:pull/22329
$ git checkout pull/22329

Update a local copy of the PR:
$ git checkout pull/22329
$ git pull https://git.openjdk.org/jdk.git pull/22329/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22329

View PR using the GUI difftool:
$ git pr show -t 22329

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22329.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344867: Cleanup unneeded qualified exports to java.rmi

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 51763b6: 8344525: Fix leftover ExceptionOccurred in java.base
  • 4b16530: 8344795: Remove uses of AccessControlContext in java.desktop module
  • 5154b71: 8343598: Since Checker can mark some preview elements as new even if bytecode reference is identical
  • 8b98f95: 8298387: Implement JEP 497: Quantum-Resistant Module-Lattice-Based Digital Signature Algorithm
  • 21e0fb8: 8343529: serviceability/sa/ClhsdbWhere.java fails AssertionFailure: Corrupted constant pool
  • 13987b4: 8298390: Implement JEP 496: Quantum-Resistant Module-Lattice-Based Key Encapsulation Mechanism

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 22, 2024
@RogerRiggs RogerRiggs changed the title 8344867: Cleanup unneded qualified exports to java.rmi 8344867: Cleanup unneeded qualified exports to java.rmi Nov 22, 2024
@openjdk
Copy link

openjdk bot commented Nov 22, 2024

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 22, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2024

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good cleanup, assuming everything builds + tests.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 22, 2024
@RogerRiggs
Copy link
Contributor Author

To be handled with other SM updates in java.rmi.

@RogerRiggs RogerRiggs closed this Nov 22, 2024
@RogerRiggs RogerRiggs deleted the 8344867-cleanup-rmi-qualified-exports branch February 24, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants