8260408: Shenandoah: adjust inline hints after JDK-8255019

[shipilev]

I was following up on performance testing results for some ongoing work, and realized that there are ShenandoahMarkContext::mark_strong calls from mark_work_loop. Those callees were supposed to be inlined. I believe it is a simple omission after JDK-8255019 moved mark_work_loop code to shenandoahMark.cpp.

On a typical workload:

# Before
[44.500s][info][gc,stats] Concurrent Marking  =    0.395 s (a =    11278 us) 
   (n =    35) (lvls, us =     6426,     9473,    11133,    12891,    16476)

# After
[44.405s][info][gc,stats] Concurrent Marking  =    0.337 s (a =     9636 us) 
   (n =    35) (lvls, us =     3770,     7383,     9785,    11328,    16776)

Additional testing:

• Eyeballing GC hot paths
• Ad-hoc performance tests

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260408: Shenandoah: adjust inline hints after JDK-8255019

Reviewers

• Roman Kennke (@rkennke - Reviewer)
• Magnus Ihse Bursie (@magicus - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2235/head:pull/2235
$ git checkout pull/2235

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[shipilev]

/label shenandoah

[openjdk]

@shipilev
The shenandoah label was successfully added.

[mlbridge]

Webrevs

• 00: Full (c83ecb8)

[rkennke]

Looks good! Thanks!

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260408: Shenandoah: adjust inline hints after JDK-8255019

Reviewed-by: rkennke, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 81a66df: 8259809: Remove PerfEvent class loading locking counters

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

Looks good from the build PoV.

[shipilev]

Thanks, GHA reports all builds are green. I would not wait for tests.

/integrate

[openjdk]

@shipilev Since your change was applied there has been 1 commit pushed to the master branch:

• 81a66df: 8259809: Remove PerfEvent class loading locking counters

Your commit was automatically rebased without conflicts.

Pushed as commit edd2707.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.