8344857: Remove calls to SecurityManager and doPrivileged in SocketExceptions and URLJarFile in the sun.net package after JEP 486 integration

[jaikiran]

Can I please get a review of this change which cleans up the usages of SecurityManager APIs from a couple of sun.net packages? This addresses https://bugs.openjdk.org/browse/JDK-8344857.

No new tests have been added and existing tests in tier1, tier2 and tier3 continue to pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344857: Remove calls to SecurityManager and doPrivileged in SocketExceptions and URLJarFile in the sun.net package after JEP 486 integration (Sub-task - P4)

Reviewers

• Daniel Fuchs (@dfuch - Reviewer)
• Michael McMahon (@Michael-Mc-Mahon - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22352/head:pull/22352
$ git checkout pull/22352

Update a local copy of the PR:
$ git checkout pull/22352
$ git pull https://git.openjdk.org/jdk.git pull/22352/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22352

View PR using the GUI difftool:
$ git pr show -t 22352

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22352.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344857: Remove calls to SecurityManager and doPrivileged  in SocketExceptions and URLJarFile in the sun.net package after JEP 486 integration

Reviewed-by: dfuchs, michaelm

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

• 08dfc4a: 8344213: Cleanup OpaqueLoop*Node verification code for Assertion Predicates
• 593a589: 8344319: SM cleanup in jdk.dynalink module
• 15ae8d0: 8319993: Update Unicode Data Files to 16.0.0
• a032de2: 8344577: Virtual thread tests are timing out on some macOS systems
• 4110d39: 8344865: SM cleanup in sun/reflect/annotation
• 1334191: 8334474: RISC-V: verify perf of ExpandBits/CompressBits (rvv)
• e29b0ed: 8344181: Remove SecurityManager and related calls from jdk.management and jdk.management.agent
• cb1c736: 8344363: FullGCForwarding::initialize_flags is called after ObjLayout::initialize
• c6b14c6: 8344841: ClassPrinter prints confusing value for null
• ddc8a9d: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages
• ... and 15 more: https://git.openjdk.org/jdk/compare/d00f31156a9ab9efcee492dfd0aaed1515df1f00...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (e078b470)

[Michael-Mc-Mahon]

LGTM

[jaikiran]

Thank you Michael and Daniel for the reviews.

[jaikiran]

/integrate

[openjdk]

Going to push as commit 3326874.
Since your change was applied there have been 31 commits pushed to the master branch:

• 48e3b65: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform
• 1623257: 8339524: Clean up a few ExtendedRobot tests
• 0276079: 8344667: Remove most uses of AWT Permissions from the desktop module
• 8de158a: 8339134: Callers of Exceptions::fthrow should ensure exception message lengths avoid the INT_MAX limits of os::vsnprintf
• df2d4c1: 8344898: SM cleanup of java.base sun/util calendar, locale, cldr, and resources
• 4d898aa: 8344896: Remove obsolete checks for AWTPermission accessClipboard
• 08dfc4a: 8344213: Cleanup OpaqueLoop*Node verification code for Assertion Predicates
• 593a589: 8344319: SM cleanup in jdk.dynalink module
• 15ae8d0: 8319993: Update Unicode Data Files to 16.0.0
• a032de2: 8344577: Virtual thread tests are timing out on some macOS systems
• ... and 21 more: https://git.openjdk.org/jdk/compare/d00f31156a9ab9efcee492dfd0aaed1515df1f00...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit 3326874.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.