8344896: Remove obsolete checks for AWTPermission accessClipboard #22356

prrace · 2024-11-25T06:53:43Z

This removes the SecurityManager related checks for clipboard access and methods which exist solely to support that.

One interesting thing is that there are two places where a method "canAccessSystemClipboard()" was not only about the SM.
In SwingUtilities and InputEvent it would return false in headless mode, regardless of whether there is an SM.
This means I have left the methods in place, behaving the same as before in headless mode.
We may be able to further simplify this later but it will be clearer with the SM-only logic removed and out of scope for this fix.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8344896: Remove obsolete checks for AWTPermission accessClipboard (Bug - P4)

Reviewers

Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22356/head:pull/22356
$ git checkout pull/22356

Update a local copy of the PR:
$ git checkout pull/22356
$ git pull https://git.openjdk.org/jdk.git pull/22356/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22356

View PR using the GUI difftool:
$ git pr show -t 22356

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22356.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-11-25T06:54:46Z

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-11-25T06:54:54Z

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344896: Remove obsolete checks for AWTPermission accessClipboard

Reviewed-by: azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

08dfc4a: 8344213: Cleanup OpaqueLoop*Node verification code for Assertion Predicates
593a589: 8344319: SM cleanup in jdk.dynalink module
15ae8d0: 8319993: Update Unicode Data Files to 16.0.0
a032de2: 8344577: Virtual thread tests are timing out on some macOS systems
4110d39: 8344865: SM cleanup in sun/reflect/annotation
1334191: 8334474: RISC-V: verify perf of ExpandBits/CompressBits (rvv)
e29b0ed: 8344181: Remove SecurityManager and related calls from jdk.management and jdk.management.agent
cb1c736: 8344363: FullGCForwarding::initialize_flags is called after ObjLayout::initialize
c6b14c6: 8344841: ClassPrinter prints confusing value for null
ddc8a9d: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages
... and 8 more: https://git.openjdk.org/jdk/compare/6f622da7fbae67d8c1cd9e795127adac58a246a9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-11-25T06:55:30Z

@prrace The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

prrace · 2024-11-25T06:57:45Z

I did not remove ACCESS_CLIPBOARD_PERMISSION from sun.awt.AWTPermissions since I am concurrently updating that class in a different PR (https://git.openjdk.org/jdk/pull/22350) , and I know that I will be able to revisit the class when deprecating java.awt.AWTPermission.
But if https://git.openjdk.org/jdk/pull/22350 is approved earlier than this one, I may add the removal here.

mlbridge · 2024-11-25T07:01:08Z

Webrevs

01: Full - Incremental (efe784a9)
00: Full (23a72b82)

azvegint

few tests use this permission indirectly:

./test/jdk/java/awt/datatransfer/Independence/IndependenceSwingTest.java:94:            sm.checkPermission(new AWTPermission("accessClipboard"));
./test/jdk/java/awt/datatransfer/Independence/IndependenceAWTTest.java:87:            sm.checkPermission(new AWTPermission("accessClipboard"));
./test/jdk/java/awt/datatransfer/SystemSelection/SystemSelectionSwingTest.java:87:                sm.checkPermission(new AWTPermission("accessClipboard"));
./test/jdk/java/awt/datatransfer/SystemSelection/SystemSelectionAWTTest.java:86:                sm.checkPermission(new AWTPermission("accessClipboard"));

src/java.desktop/share/classes/java/awt/event/InputEvent.java

azvegint · 2024-11-25T15:16:23Z

src/java.desktop/unix/classes/sun/awt/X11/XToolkit.java

-        @SuppressWarnings("removal")
-        SecurityManager security = System.getSecurityManager();
-        if (security != null) {
-            security.checkPermission(AWTPermissions.ACCESS_CLIPBOARD_PERMISSION);


import java.util.Hashtable;
import sun.awt.AWTPermissions;

can be removed

src/java.desktop/windows/classes/sun/awt/windows/WToolkit.java

prrace · 2024-11-25T18:31:03Z

few tests use this permission indirectly:

./test/jdk/java/awt/datatransfer/Independence/IndependenceSwingTest.java:94:            sm.checkPermission(new AWTPermission("accessClipboard"));
./test/jdk/java/awt/datatransfer/Independence/IndependenceAWTTest.java:87:            sm.checkPermission(new AWTPermission("accessClipboard"));
./test/jdk/java/awt/datatransfer/SystemSelection/SystemSelectionSwingTest.java:87:                sm.checkPermission(new AWTPermission("accessClipboard"));
./test/jdk/java/awt/datatransfer/SystemSelection/SystemSelectionAWTTest.java:86:                sm.checkPermission(new AWTPermission("accessClipboard"));

I had listed these bugs in https://bugs.openjdk.org/browse/JDK-8344654 for @honkar-jdk to update.
I will check with her if she will get to these soon, otherwise I can address them here.

azvegint

I had listed these bugs in https://bugs.openjdk.org/browse/JDK-8344654 for @honkar-jdk to update.
I will check with her if she will get to these soon, otherwise I can address them here.

Good to know, I guess we can leave them for the JDK-8344654 then.

honkar-jdk · 2024-11-25T19:00:15Z

@azvegint

I had listed these bugs in https://bugs.openjdk.org/browse/JDK-8344654 for @honkar-jdk to update.
I will check with her if she will get to these soon, otherwise I can address them here.

I have these tests updated as part of the JBS mentioned above (not created a PR yet).

prrace · 2024-11-25T19:30:44Z

/integrate

openjdk · 2024-11-25T19:31:25Z

Going to push as commit 4d898aa.
Since your change was applied there have been 18 commits pushed to the master branch:

08dfc4a: 8344213: Cleanup OpaqueLoop*Node verification code for Assertion Predicates
593a589: 8344319: SM cleanup in jdk.dynalink module
15ae8d0: 8319993: Update Unicode Data Files to 16.0.0
a032de2: 8344577: Virtual thread tests are timing out on some macOS systems
4110d39: 8344865: SM cleanup in sun/reflect/annotation
1334191: 8334474: RISC-V: verify perf of ExpandBits/CompressBits (rvv)
e29b0ed: 8344181: Remove SecurityManager and related calls from jdk.management and jdk.management.agent
cb1c736: 8344363: FullGCForwarding::initialize_flags is called after ObjLayout::initialize
c6b14c6: 8344841: ClassPrinter prints confusing value for null
ddc8a9d: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages
... and 8 more: https://git.openjdk.org/jdk/compare/6f622da7fbae67d8c1cd9e795127adac58a246a9...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-11-25T19:31:36Z

@prrace Pushed as commit 4d898aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8344896

23a72b8

openjdk bot changed the title ~~8344896~~ 8344896: Remove obsolete checks for AWTPermission accessClipboard Nov 25, 2024

openjdk bot added the rfr Pull request is ready for review label Nov 25, 2024

openjdk bot added the client client-libs-dev@openjdk.org label Nov 25, 2024

azvegint reviewed Nov 25, 2024

View reviewed changes

8344896

efe784a

azvegint approved these changes Nov 25, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 25, 2024

openjdk bot added the integrated Pull request has been integrated label Nov 25, 2024

openjdk bot closed this Nov 25, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 25, 2024

8344896: Remove obsolete checks for AWTPermission accessClipboard #22356

8344896: Remove obsolete checks for AWTPermission accessClipboard #22356

Uh oh!

Conversation

prrace commented Nov 25, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Nov 25, 2024

Uh oh!

openjdk bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Nov 25, 2024

Uh oh!

prrace commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Nov 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

azvegint left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

azvegint Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

prrace Nov 25, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

prrace commented Nov 25, 2024

Uh oh!

azvegint left a comment

Choose a reason for hiding this comment

Uh oh!

honkar-jdk commented Nov 25, 2024

Uh oh!

prrace commented Nov 25, 2024

Uh oh!

openjdk bot commented Nov 25, 2024

Uh oh!

openjdk bot commented Nov 25, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

prrace commented Nov 25, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Nov 25, 2024 •

edited

Loading

prrace commented Nov 25, 2024 •

edited

Loading

mlbridge bot commented Nov 25, 2024 •

edited

Loading

azvegint left a comment •

edited

Loading