8344577: Virtual thread tests are timing out on some macOS systems

[AlanBateman]

As part of JEP 491, and prep for (e.g. 8336254), we added more tests to test/jdk/java/lang/Thread/virtual to stress several critical areas. A few of these tests can take a long time on older macos-x64 hardware, esp. those with HT enabled as jtreg -concurrency gets computed to a high value. Some of these tests have spinning threads and end up competing with other tests. This directory used to have a TEST.properties with exclusive.dirs=. to prevent these tests running concurrently with each other but we decided to remove it when the number of tests increased (at one point, tests were waiting several minutes to execute because they couldn't run concurrently with other tests in the directory).

This PR proposes a few adjustments:

• Dial down 3 tests (GetStackTraceALotWhenBlocking, GetStackTraceALotWhenPinned.java, and ParkALot) on macosx-x64. This is done in the test main to avoid doubling the number of test descriptions on these tests.
• Dial down 2 runs of one test (TimedWaitALot #timeout-notify #timeout-interrupt) on all platforms. No change to the other 2 runs of this test.
• Add progress output/tracing to ParkALot.
• Remove "/othervm" from a few tests where that don't need it.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344577: Virtual thread tests are timing out on some macOS systems (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22357/head:pull/22357
$ git checkout pull/22357

Update a local copy of the PR:
$ git checkout pull/22357
$ git pull https://git.openjdk.org/jdk.git pull/22357/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22357

View PR using the GUI difftool:
$ git pr show -t 22357

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22357.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344577: Virtual thread tests are timing out on some macOS systems

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 1334191: 8334474: RISC-V: verify perf of ExpandBits/CompressBits (rvv)
• e29b0ed: 8344181: Remove SecurityManager and related calls from jdk.management and jdk.management.agent
• cb1c736: 8344363: FullGCForwarding::initialize_flags is called after ObjLayout::initialize
• c6b14c6: 8344841: ClassPrinter prints confusing value for null
• ddc8a9d: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages
• 965aace: 8335468: [XWayland] JavaFX hangs when calling java.awt.Robot.getPixelColor
• 811d08c: 8340010: Fix vectorization tests with compact headers
• 519bb26: 8344217: Remove calls to SecurityManager and doPrivileged in java.net.DatagramSocket and java.net.NetMulticastSocket after JEP 486 integration
• d112f35: 8344855: Remove calls to SecurityManager and doPrivileged in HTTP related implementation classes in the sun.net and sun.net.www.http packages after JEP 486 integration
• da4b7a8: 8341436: containers/docker/TestJcmdWithSideCar.java takes needlessly long to run
• ... and 6 more: https://git.openjdk.org/jdk/compare/6711e1327a76782c8315b9e85525e1408657727b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@AlanBateman The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bb8971db)

[jaikiran]

These test-only changes look OK to me. Is it intentional that only one of the test definitions of SleepALot has been updated to remove /othervm instead of both?

[AlanBateman]

These test-only changes look OK to me. Is it intentional that only one of the test definitions of SleepALot has been updated to remove /othervm instead of both?

There are a few tests that override the default timeout with othervm/timeout=NNN. I didn't change them but if there aren't other settings set then I think jtreg will allow it (in these tests, the only reason to fork a new VM is because of VM options (mostly) and a few that need other configuration). So I'll leave it for now, but thanks for bringing it up.

[AlanBateman]

/integrate

[openjdk]

Going to push as commit a032de2.
Since your change was applied there have been 17 commits pushed to the master branch:

• 4110d39: 8344865: SM cleanup in sun/reflect/annotation
• 1334191: 8334474: RISC-V: verify perf of ExpandBits/CompressBits (rvv)
• e29b0ed: 8344181: Remove SecurityManager and related calls from jdk.management and jdk.management.agent
• cb1c736: 8344363: FullGCForwarding::initialize_flags is called after ObjLayout::initialize
• c6b14c6: 8344841: ClassPrinter prints confusing value for null
• ddc8a9d: 8344366: Remove Security Manager dependencies from javax.net.ssl and sun.security.ssl packages
• 965aace: 8335468: [XWayland] JavaFX hangs when calling java.awt.Robot.getPixelColor
• 811d08c: 8340010: Fix vectorization tests with compact headers
• 519bb26: 8344217: Remove calls to SecurityManager and doPrivileged in java.net.DatagramSocket and java.net.NetMulticastSocket after JEP 486 integration
• d112f35: 8344855: Remove calls to SecurityManager and doPrivileged in HTTP related implementation classes in the sun.net and sun.net.www.http packages after JEP 486 integration
• ... and 7 more: https://git.openjdk.org/jdk/compare/6711e1327a76782c8315b9e85525e1408657727b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman Pushed as commit a032de2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.