Skip to content

8344954: Linker tests fails on BE platforms after JDK-8340205 #22362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

minborg
Copy link
Contributor

@minborg minborg commented Nov 25, 2024

This PR proposes to fix some tests that fails on big-endian platforms.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344954: Linker tests fails on BE platforms after JDK-8340205 (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22362/head:pull/22362
$ git checkout pull/22362

Update a local copy of the PR:
$ git checkout pull/22362
$ git pull https://git.openjdk.org/jdk.git pull/22362/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22362

View PR using the GUI difftool:
$ git pr show -t 22362

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22362.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2024

👋 Welcome back pminborg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 25, 2024

@minborg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344954: Linker tests fails on BE platforms after JDK-8340205

Reviewed-by: mdoerr, amitkumar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 4d4cef8: 8344337: SecurityManager cleanup in java.prefs module
  • 1c7f34d: 8345000: Remove last mentions of sun.awt.AWTPermissions
  • 5e0d42b: 8344916: RISC-V: Misaligned access in array fill stub
  • 3326874: 8344857: Remove calls to SecurityManager and doPrivileged in SocketExceptions and URLJarFile in the sun.net package after JEP 486 integration
  • 48e3b65: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform
  • 1623257: 8339524: Clean up a few ExtendedRobot tests
  • 0276079: 8344667: Remove most uses of AWT Permissions from the desktop module
  • 8de158a: 8339134: Callers of Exceptions::fthrow should ensure exception message lengths avoid the INT_MAX limits of os::vsnprintf
  • df2d4c1: 8344898: SM cleanup of java.base sun/util calendar, locale, cldr, and resources
  • 4d898aa: 8344896: Remove obsolete checks for AWTPermission accessClipboard
  • ... and 16 more: https://git.openjdk.org/jdk/compare/9576546b9c0f22b0784c4f845f2694050cae2f16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Nov 25, 2024

@minborg The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 25, 2024
@minborg minborg marked this pull request as ready for review November 25, 2024 14:47
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 25, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2024

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the test failures on AIX.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 25, 2024
Copy link
Member

@offamitkumar offamitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes the issue for s390x as well.

@minborg
Copy link
Contributor Author

minborg commented Nov 26, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 26, 2024

Going to push as commit 4e68d66.
Since your change was applied there have been 28 commits pushed to the master branch:

  • ca81ab5: 8344994: Remove most uses of RuntimePermission checks in java.desktop
  • 43603ac: 8344894: Obsolete reference to checking permissions in java.awt.Composite
  • 4d4cef8: 8344337: SecurityManager cleanup in java.prefs module
  • 1c7f34d: 8345000: Remove last mentions of sun.awt.AWTPermissions
  • 5e0d42b: 8344916: RISC-V: Misaligned access in array fill stub
  • 3326874: 8344857: Remove calls to SecurityManager and doPrivileged in SocketExceptions and URLJarFile in the sun.net package after JEP 486 integration
  • 48e3b65: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform
  • 1623257: 8339524: Clean up a few ExtendedRobot tests
  • 0276079: 8344667: Remove most uses of AWT Permissions from the desktop module
  • 8de158a: 8339134: Callers of Exceptions::fthrow should ensure exception message lengths avoid the INT_MAX limits of os::vsnprintf
  • ... and 18 more: https://git.openjdk.org/jdk/compare/9576546b9c0f22b0784c4f845f2694050cae2f16...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 26, 2024
@openjdk openjdk bot closed this Nov 26, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 26, 2024
@openjdk
Copy link

openjdk bot commented Nov 26, 2024

@minborg Pushed as commit 4e68d66.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr
Copy link
Contributor

Thanks for fixing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants