-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8340731: Cleanup remaining IA64 references in hotspot code #22382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into |
@offamitkumar This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 39 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@offamitkumar The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@offamitkumar thanks for taking up this cleanup!
Generally looks okay, a couple of nits and queries.
Thanks
Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please wait for second review before integrating.
all GHA test passed. Look like we are good to go. Thanks for the reviews Andrew, David. /integrate |
Going to push as commit a0df0a5.
Your commit was automatically rebased without conflicts. |
@offamitkumar Pushed as commit a0df0a5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This PR cleans up
IA64
entries form hotspot codebase.As mentioned in the JBS, I left
zero
component as-it-is:Fastdebug VM Build on Mac-M1 & Linux/s390x is fine. Tests are in progress.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22382/head:pull/22382
$ git checkout pull/22382
Update a local copy of the PR:
$ git checkout pull/22382
$ git pull https://git.openjdk.org/jdk.git pull/22382/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22382
View PR using the GUI difftool:
$ git pr show -t 22382
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22382.diff
Using Webrev
Link to Webrev Comment