Skip to content

8340731: Cleanup remaining IA64 references in hotspot code #22382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

offamitkumar
Copy link
Member

@offamitkumar offamitkumar commented Nov 26, 2024

This PR cleans up IA64 entries form hotspot codebase.

As mentioned in the JBS, I left zero component as-it-is:

./cpu/zero/bytecodeInterpreter_zero.hpp:31:#if defined(PPC) || defined(IA64)
./os_cpu/linux_zero/os_linux_zero.cpp:350:#ifdef IA64
./os_cpu/linux_zero/os_linux_zero.cpp:351:    // IA64 has two stacks sharing the same area of memory, a normal
./os_cpu/linux_zero/os_linux_zero.cpp:360:#endif // IA64

Fastdebug VM Build on Mac-M1 & Linux/s390x is fine. Tests are in progress.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8340731: Cleanup remaining IA64 references in hotspot code (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22382/head:pull/22382
$ git checkout pull/22382

Update a local copy of the PR:
$ git checkout pull/22382
$ git pull https://git.openjdk.org/jdk.git pull/22382/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22382

View PR using the GUI difftool:
$ git pr show -t 22382

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22382.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2024

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 26, 2024

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8340731: Cleanup remaining IA64 references in hotspot code

Reviewed-by: dholmes, aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

  • eb0d1ce: 8344355: Register corruption in MacroAssembler::lookup_secondary_supers_table_var: x86-64 only
  • 82137db: 8345047: RISC-V: Remove explicit use of AvoidUnalignedAccesses in interpreter
  • b3986bd: 8344118: C2 SuperWord: add VectorThroughputForIterationCount benchmark
  • 96388be: 8345004: [BACKOUT] GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox.
  • 4ae6ce6: 8344300: Implement JEP 499: Structured Concurrency (Fourth Preview)
  • 57ee3ba: 8344912: Sharpen the return type of various internal methods in jdk.internal.foreign
  • 1f6144e: 8345050: Fix -Wzero-as-null-pointer warning in MemPointer ctor
  • 08c1f44: 8341028: Do not use lambdas or method refs for verifyConstantPool
  • 28c8729: 8343004: Adjust JAXP limits
  • 8c2b4f6: 8345057: ML_KEM NamedParameterSpec constants removed by ML-DSA integration
  • ... and 29 more: https://git.openjdk.org/jdk/compare/4d4cef800a4b763ab00e93e7a76a5ca5040ab826...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8340731 8340731: Cleanup remaining IA64 references in hotspot code Nov 26, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 26, 2024
@openjdk
Copy link

openjdk bot commented Nov 26, 2024

@offamitkumar The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 26, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 26, 2024

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@offamitkumar thanks for taking up this cleanup!

Generally looks okay, a couple of nits and queries.

Thanks

offamitkumar and others added 5 commits November 26, 2024 12:55
Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
Co-authored-by: David Holmes <62092539+dholmes-ora@users.noreply.github.com>
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please wait for second review before integrating.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 27, 2024
@offamitkumar
Copy link
Member Author

all GHA test passed. Look like we are good to go. Thanks for the reviews Andrew, David.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 28, 2024

Going to push as commit a0df0a5.
Since your change was applied there have been 59 commits pushed to the master branch:

  • 8485cb1: 8344822: CDS BulkLoaderTest.java#dynamic fails with COH
  • f51363e: 8344913: Improve -Xlog:cds+map+oop logging for Java mirrors
  • cf5ee0b: 8342280: Deprecate for removal java.awt.AWTPermission
  • 8ad0b2a: 8345001: java/awt/doc-files/FocusSpec.html has SecurityManager references
  • f6d2990: 8344824: CDS dump crashes when member_method of a lambda proxy is null
  • 15378a7: 8345126: [BACKOUT] JDK-8318127: align_up has potential overflow
  • 880f9a7: 8344220: Remove calls to SecurityManager and doPrivileged in java.net.InetAddress and sun.net.util.IPAddressUtil after JEP 486 integration
  • 9527586: 8345073: Remove SecurityManager checks from sun.awt.image classes
  • 1e3a0fd: 8035271: Incorrect indentation of LineNumberTable/LocalVariableTable/Exception table/LocalVariableTypeTable/StackMapTable/RuntimeVisibleTypeAnnotations in verbose mode
  • 0312694: 8344882: (bf) Temporary direct buffers should not count against the upper limit on direct buffer memory
  • ... and 49 more: https://git.openjdk.org/jdk/compare/4d4cef800a4b763ab00e93e7a76a5ca5040ab826...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2024
@openjdk openjdk bot closed this Nov 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 28, 2024
@openjdk
Copy link

openjdk bot commented Nov 28, 2024

@offamitkumar Pushed as commit a0df0a5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@offamitkumar offamitkumar deleted the ia64_cleanup branch December 27, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants