Skip to content

8344555: SM cleanup - drop reflection filter of System.security field #22400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Nov 26, 2024

The java.lang.Sytem.security field no longer exists; remove it from the filterMap.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344555: SM cleanup - drop reflection filter of System.security field (Bug - P4)

Reviewers

Reviewers without OpenJDK IDs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22400/head:pull/22400
$ git checkout pull/22400

Update a local copy of the PR:
$ git checkout pull/22400
$ git pull https://git.openjdk.org/jdk.git pull/22400/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22400

View PR using the GUI difftool:
$ git pr show -t 22400

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22400.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 26, 2024

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 26, 2024

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344555: SM cleanup - drop reflection filter of System.security field

Reviewed-by: mullan, mchung, liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 23 new commits pushed to the master branch:

  • 4a22c1f: 8344770: Switch jpackage unit tests to use JUnit5
  • 4948062: 8318127: align_up has potential overflow
  • 461ffaf: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor
  • eb0d1ce: 8344355: Register corruption in MacroAssembler::lookup_secondary_supers_table_var: x86-64 only
  • 82137db: 8345047: RISC-V: Remove explicit use of AvoidUnalignedAccesses in interpreter
  • b3986bd: 8344118: C2 SuperWord: add VectorThroughputForIterationCount benchmark
  • 96388be: 8345004: [BACKOUT] GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox.
  • 4ae6ce6: 8344300: Implement JEP 499: Structured Concurrency (Fourth Preview)
  • 57ee3ba: 8344912: Sharpen the return type of various internal methods in jdk.internal.foreign
  • 1f6144e: 8345050: Fix -Wzero-as-null-pointer warning in MemPointer ctor
  • ... and 13 more: https://git.openjdk.org/jdk/compare/d752f19611f7d2a83b4d5356c37e6c8ff02543fd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 26, 2024
@openjdk
Copy link

openjdk bot commented Nov 26, 2024

@RogerRiggs The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 26, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 26, 2024

Webrevs

Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright should be updated.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 26, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 26, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 26, 2024
@RogerRiggs
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 27, 2024

Going to push as commit 35bd2f3.
Since your change was applied there have been 28 commits pushed to the master branch:

  • a491564: 8342836: Automatically determine that a test in the docs test root is requested
  • b89cba7: 8342808: Javadoc should add whitespace between type parameters
  • 0b704a2: 8343239: Javadoc marks non-preview type as preview if it's the subtype of a preview type
  • ac3bbf7: 8344856: Remove calls to SecurityManager and doPrivileged in sun.net.www.protocol.ftp.FtpURLConnection after JEP 486 integration
  • a1473ec: 8294432: Add provisions to calculate hash values from MemorySegments
  • 4a22c1f: 8344770: Switch jpackage unit tests to use JUnit5
  • 4948062: 8318127: align_up has potential overflow
  • 461ffaf: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor
  • eb0d1ce: 8344355: Register corruption in MacroAssembler::lookup_secondary_supers_table_var: x86-64 only
  • 82137db: 8345047: RISC-V: Remove explicit use of AvoidUnalignedAccesses in interpreter
  • ... and 18 more: https://git.openjdk.org/jdk/compare/d752f19611f7d2a83b4d5356c37e6c8ff02543fd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 27, 2024
@openjdk openjdk bot closed this Nov 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 27, 2024
@openjdk
Copy link

openjdk bot commented Nov 27, 2024

@RogerRiggs Pushed as commit 35bd2f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8344555-sm-noreflect branch February 24, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants