8344987: Test serviceability/sa/TestJhsdbJstackPrintVMLocks.java fails: NoClassDefFoundError: jdk/test/lib/Utils

[lmesnik]

The real bug is
https://bugs.openjdk.org/browse/CODETOOLS-7902847 Class directory of a test case should not be used to compile a library

and the following workaround just excludes the testing group where it fails often.

There is no plans to update test right now. The jtreg should be fixed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344987: Test serviceability/sa/TestJhsdbJstackPrintVMLocks.java fails: NoClassDefFoundError: jdk/test/lib/Utils (Bug - P4)

Reviewers

• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22405/head:pull/22405
$ git checkout pull/22405

Update a local copy of the PR:
$ git checkout pull/22405
$ git pull https://git.openjdk.org/jdk.git pull/22405/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22405

View PR using the GUI difftool:
$ git pr show -t 22405

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22405.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344987: Test serviceability/sa/TestJhsdbJstackPrintVMLocks.java fails: NoClassDefFoundError: jdk/test/lib/Utils

Reviewed-by: cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 133 new commits pushed to the master branch:

• a49f077: 8345221: Replace legacy with new Provider APIs in SunNativeGSS
• 2be07b5: 8324491: Keyboard layout didn't keep its state if it was changed when dialog was active
• f37f64d: 8343736: Test java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java failed: Choice can't be controlled by keyboard
• 73b8b34: 8344368: IndependenceSwingTest.java and IndependenceAWTTest.java failed: Selected text & clipboard contents differs
• 9267dfa: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19
• 293323c: 8340141: C1: rework ciMethod::equals following 8338471
• 76e874c: 8345319: Fix the tag type in PoolEntry and AnnotationValue
• e9f6ba0: 8345293: Fix generational Shenandoah with compact headers
• e1910f2: 8345397: Remove from g1HeapRegionRemSet.cpp
• 3c60f0b: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed
• ... and 123 more: https://git.openjdk.org/jdk/compare/65c98e577f72bfe544d7e6b5e9d1568667d208fa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lmesnik The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (23f9a78c)

[sendaoYan]

How about exclude this test in test/hotspot/jtreg/ProblemList.txt, add a problemlist entry like serviceability/sa/TestJhsdbJstackPrintVMLocks.java CODETOOLS-7902847 generic-all, since this test will be convenient re-enable after CODETOOLS-7902847 been fixed.

[dholmes-ora]

@sendaoYan adding to the PL will mean the test never runs. With the proposed change it will still run in tier1_serviceability where it has not been seen to fail, but will no longer run in the problematic tier4 grouping. This seems a reasonable compromise. That said we have modified a number of tests to workaround the CODETOOLS issue, so we could do that here as well.

[sendaoYan]

@sendaoYan adding to the PL will mean the test never runs. With the proposed change it will still run in tier1_serviceability where it has not been seen to fail, but will no longer run in the problematic tier4 grouping.

Thanks David's explanation.

[lmesnik]

/cc hotspot-runtime
/cc serviceability

[openjdk]

@lmesnik
The hotspot-runtime label was successfully added.

[openjdk]

@lmesnik
The serviceability label was successfully added.

[lmesnik]

/integrate

[openjdk]

Going to push as commit 0664b51.
Since your change was applied there have been 134 commits pushed to the master branch:

• 157a434: 8345389: Bump missed copyright years for JDK-8336768
• a49f077: 8345221: Replace legacy with new Provider APIs in SunNativeGSS
• 2be07b5: 8324491: Keyboard layout didn't keep its state if it was changed when dialog was active
• f37f64d: 8343736: Test java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java failed: Choice can't be controlled by keyboard
• 73b8b34: 8344368: IndependenceSwingTest.java and IndependenceAWTTest.java failed: Selected text & clipboard contents differs
• 9267dfa: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19
• 293323c: 8340141: C1: rework ciMethod::equals following 8338471
• 76e874c: 8345319: Fix the tag type in PoolEntry and AnnotationValue
• e9f6ba0: 8345293: Fix generational Shenandoah with compact headers
• e1910f2: 8345397: Remove from g1HeapRegionRemSet.cpp
• ... and 124 more: https://git.openjdk.org/jdk/compare/65c98e577f72bfe544d7e6b5e9d1568667d208fa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lmesnik Pushed as commit 0664b51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.