Skip to content

Conversation

@vy
Copy link
Contributor

@vy vy commented Nov 27, 2024

This change set, addressing 8344856, removes SecurityManager and friends from sun.net.www.protocol.ftp.FtpURLConnection. This is the only leftover from SM cleanup in the subclasses of URLConnection in the sun.net package. Successful tier1..3 CI runs on b02813b are shared in the ticket.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344856: Remove calls to SecurityManager and doPrivileged in sun.net.www.protocol.ftp.FtpURLConnection after JEP 486 integration (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22407/head:pull/22407
$ git checkout pull/22407

Update a local copy of the PR:
$ git checkout pull/22407
$ git pull https://git.openjdk.org/jdk.git pull/22407/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22407

View PR using the GUI difftool:
$ git pr show -t 22407

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22407.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2024

👋 Welcome back vy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 27, 2024

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344856: Remove calls to SecurityManager and doPrivileged in sun.net.www.protocol.ftp.FtpURLConnection after JEP 486 integration

Reviewed-by: dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • eb0d1ce: 8344355: Register corruption in MacroAssembler::lookup_secondary_supers_table_var: x86-64 only
  • 82137db: 8345047: RISC-V: Remove explicit use of AvoidUnalignedAccesses in interpreter
  • b3986bd: 8344118: C2 SuperWord: add VectorThroughputForIterationCount benchmark
  • 96388be: 8345004: [BACKOUT] GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox.
  • 4ae6ce6: 8344300: Implement JEP 499: Structured Concurrency (Fourth Preview)
  • 57ee3ba: 8344912: Sharpen the return type of various internal methods in jdk.internal.foreign
  • 1f6144e: 8345050: Fix -Wzero-as-null-pointer warning in MemPointer ctor
  • 08c1f44: 8341028: Do not use lambdas or method refs for verifyConstantPool
  • 28c8729: 8343004: Adjust JAXP limits

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title 8344856: Remove calls to SecurityManager and doPrivileged in subclasses of URLConnection in the sun.net package after JEP 486 integration 8344856: Remove calls to SecurityManager and doPrivileged in subclasses of URLConnection in the sun.net package after JEP 486 integration Nov 27, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 27, 2024
@openjdk
Copy link

openjdk bot commented Nov 27, 2024

@vy The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Nov 27, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 27, 2024
@vy vy changed the title 8344856: Remove calls to SecurityManager and doPrivileged in subclasses of URLConnection in the sun.net package after JEP 486 integration 8344856: Remove calls to SecurityManager and doPrivileged in sun.net.www.protocol.ftp.FtpURLConnection after JEP 486 integration Nov 27, 2024
@vy
Copy link
Contributor Author

vy commented Nov 27, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 27, 2024
@openjdk
Copy link

openjdk bot commented Nov 27, 2024

@vy
Your change (at version 9b30465) is now ready to be sponsored by a Committer.

@dfuch
Copy link
Member

dfuch commented Nov 27, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 27, 2024

Going to push as commit ac3bbf7.
Since your change was applied there have been 13 commits pushed to the master branch:

  • a1473ec: 8294432: Add provisions to calculate hash values from MemorySegments
  • 4a22c1f: 8344770: Switch jpackage unit tests to use JUnit5
  • 4948062: 8318127: align_up has potential overflow
  • 461ffaf: 8331735: UpcallLinker::on_exit races with GC when copying frame anchor
  • eb0d1ce: 8344355: Register corruption in MacroAssembler::lookup_secondary_supers_table_var: x86-64 only
  • 82137db: 8345047: RISC-V: Remove explicit use of AvoidUnalignedAccesses in interpreter
  • b3986bd: 8344118: C2 SuperWord: add VectorThroughputForIterationCount benchmark
  • 96388be: 8345004: [BACKOUT] GTK & Nimbus LAF: Tabbed pane's background color is not expected one when change the opaque checkbox.
  • 4ae6ce6: 8344300: Implement JEP 499: Structured Concurrency (Fourth Preview)
  • 57ee3ba: 8344912: Sharpen the return type of various internal methods in jdk.internal.foreign
  • ... and 3 more: https://git.openjdk.org/jdk/compare/8c2b4f62714f26ab3bc4808c734502af632a1eef...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 27, 2024
@openjdk openjdk bot closed this Nov 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 27, 2024
@openjdk
Copy link

openjdk bot commented Nov 27, 2024

@dfuch @vy Pushed as commit ac3bbf7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vy vy deleted the SM-FtpUrlCon branch November 29, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated net net-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants