8324491: Keyboard layout didn't keep its state if it was changed when dialog was active

[dmarkov20]

If AWT/Swing app displays several windows and an user changes the keyboard layout and then closes the focused window, the app does not keep the keyboard layout changes.

It is necessary to sync currentLocale and Windows keyboard layout values in WInputMethod class before component activation.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8324491: Keyboard layout didn't keep its state if it was changed when dialog was active (Bug - P3)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22411/head:pull/22411
$ git checkout pull/22411

Update a local copy of the PR:
$ git checkout pull/22411
$ git pull https://git.openjdk.org/jdk.git pull/22411/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22411

View PR using the GUI difftool:
$ git pr show -t 22411

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22411.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dmarkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dmarkov20 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324491: Keyboard layout didn't keep its state if it was changed when dialog was active

Reviewed-by: aivanov, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 111 new commits pushed to the master branch:

• f37f64d: 8343736: Test java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java failed: Choice can't be controlled by keyboard
• 73b8b34: 8344368: IndependenceSwingTest.java and IndependenceAWTTest.java failed: Selected text & clipboard contents differs
• 9267dfa: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19
• 293323c: 8340141: C1: rework ciMethod::equals following 8338471
• 76e874c: 8345319: Fix the tag type in PoolEntry and AnnotationValue
• e9f6ba0: 8345293: Fix generational Shenandoah with compact headers
• e1910f2: 8345397: Remove from g1HeapRegionRemSet.cpp
• 3c60f0b: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed
• 3eaa761: 8342086: FileInputStream.available() fails with "Incorrect function" for "nul" path (win)
• 60bd73a: 8342089: Require --enable-native-access to be the same between CDS dump time and run time
• ... and 101 more: https://git.openjdk.org/jdk/compare/494806286f126b29b7fc6eb217fa2ae26f295072...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dmarkov20 The following labels will be automatically applied to this pull request:

• client
• i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (46f0f743)

[dmarkov20]

Looking for volunteers to review the fix.
Thanks in advance

[aivanov-jdk]

Looks good to me.

The keyboard layout is preserved after closing the dialog. I used SwingSet2 and Show Input Dialog to test the changes.

[dmarkov20]

/integrate

[openjdk]

Going to push as commit 2be07b5.
Since your change was applied there have been 111 commits pushed to the master branch:

• f37f64d: 8343736: Test java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java failed: Choice can't be controlled by keyboard
• 73b8b34: 8344368: IndependenceSwingTest.java and IndependenceAWTTest.java failed: Selected text & clipboard contents differs
• 9267dfa: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19
• 293323c: 8340141: C1: rework ciMethod::equals following 8338471
• 76e874c: 8345319: Fix the tag type in PoolEntry and AnnotationValue
• e9f6ba0: 8345293: Fix generational Shenandoah with compact headers
• e1910f2: 8345397: Remove from g1HeapRegionRemSet.cpp
• 3c60f0b: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed
• 3eaa761: 8342086: FileInputStream.available() fails with "Incorrect function" for "nul" path (win)
• 60bd73a: 8342089: Require --enable-native-access to be the same between CDS dump time and run time
• ... and 101 more: https://git.openjdk.org/jdk/compare/494806286f126b29b7fc6eb217fa2ae26f295072...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dmarkov20 Pushed as commit 2be07b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.