8268145: [macos] Rendering artifacts is seen when text inside the JTable with TableCellEditor having JTextfield #22416

prsadhuk · 2024-11-27T16:22:49Z

When a textfield is embedded in a TableCellEditor in a JTable in Aqua L&F and space is entered and caret moved back and forth by pressing left/right arrow button, an artifact is seen, which is basically the caret is not properly repainted leaving behind its trails.

When caret is moved, it is repainted every time by "damaging" the area surrounding the caret to cause it to be repainted in a new location. AquaCaret overrides the default "damage" code to intersect the caret area with the border insets so that it does not damage the AquaBorder area..
For TextField case, AquaTextFieldBorder insets is removed from AquaTextField and then intersected with AquaCaret to get the dirry region which is then repainted, so as to not damage the border but it is done irrespective of whether border is shown or not, so proper dirty region is not repainted leaving behind artifacts when the caret is moved around...

Fix is to see if border to be painted is not opaque in which case the proper dirty region is calculated which is then used in repaint logic to repaint the component..

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8268145: [macos] Rendering artifacts is seen when text inside the JTable with TableCellEditor having JTextfield (Bug - P4)

Reviewers

Alexander Zuev (@azuev-java - Reviewer)
Abhishek Kumar (@kumarabhi006 - Reviewer)
Harshitha Onkar (@honkar-jdk - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22416/head:pull/22416
$ git checkout pull/22416

Update a local copy of the PR:
$ git checkout pull/22416
$ git pull https://git.openjdk.org/jdk.git pull/22416/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22416

View PR using the GUI difftool:
$ git pr show -t 22416

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22416.diff

Using Webrev

Link to Webrev Comment

…ble with TableCellEditor having JTextfield

bridgekeeper · 2024-11-27T16:23:36Z

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-11-27T16:23:54Z

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268145: [macos] Rendering artifacts is seen when text inside the JTable with TableCellEditor having JTextfield

Reviewed-by: kizune, abhiscxk, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 218 new commits pushed to the master branch:

5cc150c: 8342979: Start of release updates for JDK 25
85fedbf: 8344607: Link Time Optimization - basic support for clang
5a0899f: 8345302: Building microbenchmarks require larger Java heap
1ece4f9: 8345514: Should use internal class name when calling ClassLoader.getResourceAsByteArray
ef8da28: 8345591: [aarch64] macroAssembler_aarch64.cpp compile fails ceil_log2 not declared
7513b13: 8328944: NMT reports "unknown" memory
691e692: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util
97b8a09: 8345339: JFR: Missing javadoc for RecordingStream::onMetadata
456c71d: 8343699: [aarch64] Bug in MacroAssembler::klass_decode_mode()
308357c: 8345578: New test in JDK-8343622 fails with a promoted build
... and 208 more: https://git.openjdk.org/jdk/compare/fc2da15bcee9560186058b3e2fd12ddcb0eb0f39...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-11-27T16:24:40Z

@prsadhuk The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2024-11-27T16:31:14Z

Webrevs

01: Full - Incremental (1797ded4)
00: Full (005ac187)

test/jdk/javax/swing/JTable/TestCaretArtifact.java

honkar-jdk · 2024-11-27T18:42:40Z

test/jdk/javax/swing/JTable/TestCaretArtifact.java

+                "inactive forever"}},
+                new Object[] {"1", "2"});
+
+        JFrame frame = new JFrame();


JFrame title is missing

honkar-jdk · 2024-11-27T18:46:47Z

src/java.desktop/macosx/classes/com/apple/laf/AquaCaret.java

+        } else {
+            x = alloc.x;
+            y = alloc.y;
+            width = alloc.width;
+            height = alloc.height;


Currently the test case tests the else branch (no border case), since the if branch is also modified, would it be better to test both cases - with and without border?

That is already being tested by existing testcases in CI and if I am not wrong by SwingSet2 too and there is no change in logic in the if branch, when it enters the branch..

kumarabhi006

Test verified and it works as expected.

honkar-jdk

TestCaretArtifact (no-border case) and SwingSet2 (with border) work as expected with the fix.

alisenchung · 2024-12-04T19:50:34Z

test/jdk/javax/swing/JTable/TestCaretArtifact.java

+        Do this few times.
+        If artifact is seen, press Fail else press Pass.""";
+
+    public static void  main(String[] args) throws Exception {


small nitpick but I think there's an extra whitespace here after void

alisenchung · 2024-12-04T19:50:48Z

test/jdk/javax/swing/JTable/TestCaretArtifact.java

+    }
+
+
+    public static JFrame createUI()  {


extra whitespace here too

prsadhuk · 2024-12-06T03:18:13Z

/integrate

openjdk · 2024-12-06T03:19:18Z

Going to push as commit 8403285.
Since your change was applied there have been 229 commits pushed to the master branch:

aa38284: 8345435: Eliminate tier1_compiler_not_xcomp group
9284602: 8345628: [BACKOUT] JDK-8287122 Use gcc12 -ftrivial-auto-var-init=pattern in debug builds
41c8971: 8287122: Use gcc12 -ftrivial-auto-var-init=pattern in debug builds
5da0eee: 8285692: Enable _FORTIFY_SOURCE=2 when building with Clang
daa2ba5: 8339622: Regression in make open-hotspot-xcode-project
6f6bce5: 8344559: Log is spammed by missing pandoc warnings when building man pages
5f30a8d: 8345424: Move FindDebuginfoFiles out of FileUtils.gmk
bf0debc: 8343890: SEGV crash in RunTimeClassInfo::klass
a97dca5: 8344593: GenShen: Review of ReduceInitialCardMarks
bedb68a: 8342444: Shenandoah: Uncommit regions from a separate, STS aware thread
... and 219 more: https://git.openjdk.org/jdk/compare/fc2da15bcee9560186058b3e2fd12ddcb0eb0f39...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-12-06T03:19:25Z

@prsadhuk Pushed as commit 8403285.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8268145: [macos] Rendering artifacts is seen when text inside the JTa…

a25e0a9

…ble with TableCellEditor having JTextfield

openjdk bot added the client client-libs-dev@openjdk.org label Nov 27, 2024

jcheck

005ac18

openjdk bot added the rfr Pull request is ready for review label Nov 27, 2024

honkar-jdk reviewed Nov 27, 2024

View reviewed changes

Test fix

1797ded

azuev-java approved these changes Nov 28, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Nov 28, 2024

kumarabhi006 approved these changes Nov 29, 2024

View reviewed changes

honkar-jdk approved these changes Dec 3, 2024

View reviewed changes

alisenchung reviewed Dec 4, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Dec 6, 2024

openjdk bot closed this Dec 6, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2024

prsadhuk deleted the JDK-8268145 branch December 6, 2024 03:19

8268145: [macos] Rendering artifacts is seen when text inside the JTable with TableCellEditor having JTextfield #22416

8268145: [macos] Rendering artifacts is seen when text inside the JTable with TableCellEditor having JTextfield #22416

Uh oh!

Conversation

prsadhuk commented Nov 27, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Nov 27, 2024

Uh oh!

openjdk bot commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Nov 27, 2024

Uh oh!

mlbridge bot commented Nov 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

honkar-jdk Nov 27, 2024

Choose a reason for hiding this comment

Uh oh!

prsadhuk Nov 28, 2024

Choose a reason for hiding this comment

Uh oh!

honkar-jdk Nov 27, 2024

Choose a reason for hiding this comment

Uh oh!

prsadhuk Nov 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kumarabhi006 left a comment

Choose a reason for hiding this comment

Uh oh!

honkar-jdk left a comment

Choose a reason for hiding this comment

Uh oh!

alisenchung Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

alisenchung Dec 4, 2024

Choose a reason for hiding this comment

Uh oh!

prsadhuk commented Dec 6, 2024

Uh oh!

openjdk bot commented Dec 6, 2024

Uh oh!

openjdk bot commented Dec 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

prsadhuk commented Nov 27, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Nov 27, 2024 •

edited

Loading

mlbridge bot commented Nov 27, 2024 •

edited

Loading

prsadhuk Nov 28, 2024 •

edited

Loading