Skip to content

Conversation

@prrace
Copy link
Contributor

@prrace prrace commented Nov 28, 2024

Remove uses of and references to SecurityManager from the printing code


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345142: Remove uses of SecurityManager in Printing related classes (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22422/head:pull/22422
$ git checkout pull/22422

Update a local copy of the PR:
$ git checkout pull/22422
$ git pull https://git.openjdk.org/jdk.git pull/22422/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22422

View PR using the GUI difftool:
$ git pr show -t 22422

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22422.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2024

👋 Welcome back prr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 28, 2024

@prrace This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345142: Remove uses of SecurityManager in Printing related classes

Reviewed-by: azvegint, psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • c40b570: 8343775: Add since checker tests to the security area modules
  • 50b4cbd: 8345102: [s390x/ppc] ShowRegistersOnAssertTest.java fails after 8343756
  • 28ae281: 8337511: Implement JEP 404: Generational Shenandoah (Experimental)
  • 029ace0: 8336041: Doccheck: the jfr command doesn't show the correct command-line options
  • 2beb2b6: 8345234: Build system erroneously treats 32-bit x86 Zero as deprecated
  • ed03f0d: 8345145: Display javap LineNumberTable and LocalVariableTable iff disassembled code output with -c or -v
  • e9136b5: 8345223: Remove stray doPrivileged in java.base java.net and sun.net classes after JEP 486 integration
  • a80ccf2: 8345039: IGV: save user-defined node colors to XML
  • 28b0f3e: 8343705: IGV: Interactive Node Moving in Hierarchical Layout
  • 4da7c35: 8314512: IGV: clean up hierarchical layout code
  • ... and 26 more: https://git.openjdk.org/jdk/compare/cf5ee0bda2e50d91673ff6bfa2d6d1dbb96fa99b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8345142 8345142: Remove uses of SecurityManager in Printing related classes Nov 28, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2024
@openjdk
Copy link

openjdk bot commented Nov 28, 2024

@prrace The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Nov 28, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 28, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Nov 30, 2024
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 2, 2024
@prrace
Copy link
Contributor Author

prrace commented Dec 2, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 2, 2024

Going to push as commit 67f18cc.
Since your change was applied there have been 50 commits pushed to the master branch:

  • 352201d: 8343788: Provide means to alter lib/tzmappings entries on Windows
  • 29c57e8: 8342677: Add IR validation tests for newly added saturated vector add / sub operations
  • 30b8bbe: 8345060: Remove Security Manager dependencies from java.security.KeyStore and Identity APIs and implementations
  • 1ca7644: 8339480: Build static-jdk image with a statically linked launcher
  • d589baf: 8345218: Clean out references to windows-x86 in jib profiles
  • b823398: 8345267: Fix memory leak in JVMCIEnv dtor
  • 9a48e4d: 8345177: RISC-V: Add gtests for cmpxchg
  • e3b679a: 8345176: Add tests to verify java.net.Socket constructors close the socket on failure
  • c7be41e: 8340133: Add concise usage message to the java executable
  • 0b0f83c: 8345220: Serial: Refactor TenuredGeneration::promotion_attempt_is_safe
  • ... and 40 more: https://git.openjdk.org/jdk/compare/cf5ee0bda2e50d91673ff6bfa2d6d1dbb96fa99b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 2, 2024
@openjdk openjdk bot closed this Dec 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 2, 2024
@openjdk
Copy link

openjdk bot commented Dec 2, 2024

@prrace Pushed as commit 67f18cc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants