8344925: translet-name ignored, when package-name is also set via TransformerFactory.setAttribute

[zhfeng]

…String)

This bug seems from the improper handling of package and class name initialization in XSLTC since there is a default value of _packageName with die.verwandlung. This fix is just adjusting to call setPackageName before setClassName.

I've done the tire1 and tire2 tests. The tire1 tests passed and tire2 reports

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR  
>> jtreg:test/hotspot/jtreg:tier2                      745   744     1     0 <<
>> jtreg:test/jdk:tier2                               4142  4137     2     3 <<
   jtreg:test/langtools:tier2                           12    12     0     0  
   jtreg:test/jaxp:tier2                               514   514     0     0  
   jtreg:test/docs:tier2                                 1     1     0     0  
==============================
TEST FAILURE

The failed tests are

JT Harness : Tests that failed
runtime/Thread/ThreadCountLimit.java#id0: Stress test that reaches the process limit for thread count, or time limit.

JT Harness : Tests that failed
java/net/InetAddress/CheckJNI.java: java -Xcheck:jni failing in net code on Solaris / [Datagram]Socket.getLocalAddress() failure
java/net/Socket/LinkLocal.java: Connecting to a link-local IPv6 address should not causes a SocketException to be thrown.

JT Harness : Tests that had errors
java/net/URL/EarlyOrDelayedParsing.java: URL built-in protocol handlers should parse the URL early to avoid constructing URLs for which openConnection would later throw an exception, when possible.
java/net/ipv6tests/UdpTest.java: IPv6 support for Windows XP and 2003 server.
java/nio/channels/DatagramChannel/SendReceiveMaxSize.java: Check that it is possible to send and receive datagrams of maximum size on macOS.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8344925

Warning

 ⚠️ Patch contains a binary file (src/java.desktop/share/classes/javax/swing/text/doc-files/Document-insert.gif)

Issue

• JDK-8344925: translet-name ignored when package-name is also set (Bug - P4) ⚠️ Title mismatch between PR and JBS. ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22425/head:pull/22425
$ git checkout pull/22425

Update a local copy of the PR:
$ git checkout pull/22425
$ git pull https://git.openjdk.org/jdk.git pull/22425/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22425

View PR using the GUI difftool:
$ git pr show -t 22425

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22425.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @zhfeng, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user zhfeng" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@zhfeng The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[zhfeng]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[jerboaa]

/covered

Zheng Feng works for Red Hat and should be covered by the RH OCA.

[jerboaa]

@robilad Could you have a look at OCA clearance for @zhfeng. Thank you!

[bridgekeeper]

@zhfeng This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[zhfeng]

Please keep it open and we will still wait for the OCA clearance.

[mlbridge]

Webrevs

• 00: Full (72e9641a)

[bridgekeeper]

@zhfeng This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[JoeWang-Java]

Sorry I missed your PR. Please note that, the right procedure to take over an issue is to ask the person assigned to the bug, get the bug assigned to you before starting any work, that would avoid confusion and duplicate work.

If you plan to work on any patch in the future, please remember to add a test. If a test is not necessary, add the relevant label.

[openjdk]

@zhfeng this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8344925
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[jerboaa]

A change similar to the proposal here has been integrated with #23446 I'd suggest to close this one. It looks like there was some miscommunication happening. In this case the person proposing the PR isn't OpenJDK author, so couldn't assign the bug to himself. We'll work with the team to catch cases like this in the future.

[zhfeng]

Thanks all of you and this is my first time to contribute to the openjdk project. I did not know the procedure and should have asked such things on the ML first. Is there any document refer to the first time contribution?

[JoeWang-Java]

Check out the OpenJDK Developers’ Guide: https://openjdk.org/guide/