8345154: IGV: Show Parse and Assertion Predicate type as extra label

[chhagedorn]

ParsePredicate and If/RangeCheck nodes for Assertion Predicates dump their respective type to the dump_spec string. We can parse this info and show it in the "Show custom node info" filter as done for other nodes already:

Thanks,
Christian

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345154: IGV: Show Parse and Assertion Predicate type as extra label (Enhancement - P4)

Reviewers

• Roberto Castañeda Lozano (@robcasloz - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22428/head:pull/22428
$ git checkout pull/22428

Update a local copy of the PR:
$ git checkout pull/22428
$ git pull https://git.openjdk.org/jdk.git pull/22428/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22428

View PR using the GUI difftool:
$ git pr show -t 22428

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22428.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345154: IGV: Show Parse and Assertion Predicate type as extra label

Reviewed-by: rcastanedalo

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 255 new commits pushed to the master branch:

• 1e086b1: 8340103: Add internal set_flag function to VMATree
• db535c8: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation
• edfe285: 8344306: RISC-V: Add zicond
• d33ad07: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands
• 56f1e4e: 8344093: Implement JEP 501: Deprecate the 32-bit x86 Port for Removal
• d791f4b: 8341585: Test java/foreign/TestUpcallStress.java should mark as /native
• e096660: 8345043: [ASAN] methodMatcher.cpp report reading from a region of size 0 [-Werror=stringop-overread]
• 1033385: 8344967: Some tests in TestFill do not use the test parameter
• 81c44e5: 8344908: URLClassPath should not propagate IllegalArgumentException when finding resources in classpath URLs
• ce9d543: 8345119: Some java/foreign tests wrongly assume aligned memory
• ... and 245 more: https://git.openjdk.org/jdk/compare/b9c6ce900b512adfcaccd2341be3eb0003a28b87...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@chhagedorn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1f53b32a)

[robcasloz]

Looks good and trivial. Thanks for doing this, Christian!

[chhagedorn]

Thanks Roberto for the review!

/integrate

[openjdk]

Going to push as commit 7dc00d3.
Since your change was applied there have been 255 commits pushed to the master branch:

• 1e086b1: 8340103: Add internal set_flag function to VMATree
• db535c8: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation
• edfe285: 8344306: RISC-V: Add zicond
• d33ad07: 8334493: Remove SecurityManager Permissions infrastructure from DiagnosticCommands
• 56f1e4e: 8344093: Implement JEP 501: Deprecate the 32-bit x86 Port for Removal
• d791f4b: 8341585: Test java/foreign/TestUpcallStress.java should mark as /native
• e096660: 8345043: [ASAN] methodMatcher.cpp report reading from a region of size 0 [-Werror=stringop-overread]
• 1033385: 8344967: Some tests in TestFill do not use the test parameter
• 81c44e5: 8344908: URLClassPath should not propagate IllegalArgumentException when finding resources in classpath URLs
• ce9d543: 8345119: Some java/foreign tests wrongly assume aligned memory
• ... and 245 more: https://git.openjdk.org/jdk/compare/b9c6ce900b512adfcaccd2341be3eb0003a28b87...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn Pushed as commit 7dc00d3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.