Skip to content

8345175: Further cleanup in java.logging and jdk.internal.logger after JEP 486 integration #22436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented Nov 28, 2024

A few minor things were missed by JDK-8344235. Some unused variables can be removed, some @SuppressWranings are now redundant and some comments ,mentioning the access control context can be deleted.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345175: Further cleanup in java.logging and jdk.internal.logger after JEP 486 integration (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22436/head:pull/22436
$ git checkout pull/22436

Update a local copy of the PR:
$ git checkout pull/22436
$ git pull https://git.openjdk.org/jdk.git pull/22436/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22436

View PR using the GUI difftool:
$ git pr show -t 22436

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22436.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2024

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 28, 2024

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345175: Further cleanup in java.logging and jdk.internal.logger after JEP 486 integration

Reviewed-by: alanb, coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • edfe285: 8344306: RISC-V: Add zicond

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2024
@openjdk
Copy link

openjdk bot commented Nov 28, 2024

@dfuch The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Nov 28, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2024

Webrevs

Copy link
Contributor

@AlanBateman AlanBateman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 28, 2024
@dfuch
Copy link
Member Author

dfuch commented Nov 28, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Nov 28, 2024

Going to push as commit 3b21a29.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 7dc00d3: 8345154: IGV: Show Parse and Assertion Predicate type as extra label
  • 1e086b1: 8340103: Add internal set_flag function to VMATree
  • db535c8: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation
  • edfe285: 8344306: RISC-V: Add zicond

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2024
@openjdk openjdk bot closed this Nov 28, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 28, 2024
@openjdk
Copy link

openjdk bot commented Nov 28, 2024

@dfuch Pushed as commit 3b21a29.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants