Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260448: Simplify ManagementFactory$PlatformMBeanFinder #2244

Closed
wants to merge 1 commit into from

Conversation

cl4es
Copy link
Member

@cl4es cl4es commented Jan 26, 2021

Simplify and desugar the static initialization of PlatformMBeanFinder.

While arguably making the code easier to comprehend, this saves 5-6ms on startup in various applications such as the spring-petclinic.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260448: Simplify ManagementFactory$PlatformMBeanFinder

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2244/head:pull/2244
$ git checkout pull/2244

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2021

👋 Welcome back redestad! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 26, 2021
@openjdk
Copy link

openjdk bot commented Jan 26, 2021

@cl4es The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jan 26, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 26, 2021

Webrevs

Copy link
Member

@mlchung mlchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@openjdk
Copy link

openjdk bot commented Jan 26, 2021

@cl4es This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260448: Simplify ManagementFactory$PlatformMBeanFinder

Reviewed-by: mchung, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • b3c8a52: 8259050: Error recovery in lexer could be improved
  • bf15c70: 8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"
  • 3e4194c: 8260022: [ppc] os::print_function_and_library_name shall resolve function descriptors transparently
  • fa40a96: 8253420: Refactor HeapRegionManager::find_highest_free
  • 4d004c9: 8260449: Remove stale declaration of SATBMarkQueue::apply_closure_and_empty()
  • fd2641e: 8260236: better init AnnotationCollector _contended_group
  • 1c77046: 8260404: jvm_io.h include missing in a number of files
  • bd2744d: 8260106: Shenandoah: refactor reference updating closures and related code
  • c836da3: 8252412: [macos11] system dynamic libraries removed from filesystem
  • e1411fd: 6606673: Path2D.Double, Path2D.Float and GeneralPath ctors throw exception when initialCapacity is negative
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/fd00ed747a92454bb993580a05cb33c55a83eb16...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 26, 2021
Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - it's a bit sad to transform lambda expressions back into for loops though ;-)

@cl4es
Copy link
Member Author

cl4es commented Jan 27, 2021

@mlchung @dfuch, thank you for reviewing

/integrate

@openjdk openjdk bot closed this Jan 27, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2021
@openjdk
Copy link

openjdk bot commented Jan 27, 2021

@cl4es Since your change was applied there have been 15 commits pushed to the master branch:

  • b3c8a52: 8259050: Error recovery in lexer could be improved
  • bf15c70: 8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"
  • 3e4194c: 8260022: [ppc] os::print_function_and_library_name shall resolve function descriptors transparently
  • fa40a96: 8253420: Refactor HeapRegionManager::find_highest_free
  • 4d004c9: 8260449: Remove stale declaration of SATBMarkQueue::apply_closure_and_empty()
  • fd2641e: 8260236: better init AnnotationCollector _contended_group
  • 1c77046: 8260404: jvm_io.h include missing in a number of files
  • bd2744d: 8260106: Shenandoah: refactor reference updating closures and related code
  • c836da3: 8252412: [macos11] system dynamic libraries removed from filesystem
  • e1411fd: 6606673: Path2D.Double, Path2D.Float and GeneralPath ctors throw exception when initialCapacity is negative
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/fd00ed747a92454bb993580a05cb33c55a83eb16...master

Your commit was automatically rebased without conflicts.

Pushed as commit e696baa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants