8343747: C2: TestReplicateAtConv.java crashes with -XX:MaxVectorSize=8

[rwestrel]

Crash occurs when attempting to create a Replicate node that's input
to a VectorCast node (for a ConvL2I) that's not supported by the
platform (when run with MaxVectorSize=8). I think the pack for the
VectorCast should be filtered out earlier as not implemented and I
propose adding a test to VectorCastNode::implemented() for the type
of its input to handle that corner case.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8343747: C2: TestReplicateAtConv.java crashes with -XX:MaxVectorSize=8 (Bug - P3)(⚠️ The fixVersion in this issue is [24] but the fixVersion in .jcheck/conf is 25, a new backport will be created when this pr is integrated.)

Reviewers

• Emanuel Peter (@eme64 - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22442/head:pull/22442
$ git checkout pull/22442

Update a local copy of the PR:
$ git checkout pull/22442
$ git pull https://git.openjdk.org/jdk.git pull/22442/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22442

View PR using the GUI difftool:
$ git pr show -t 22442

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22442.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8343747: C2: TestReplicateAtConv.java crashes with -XX:MaxVectorSize=8

Reviewed-by: epeter, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 158 new commits pushed to the master branch:

• 5cc150c: 8342979: Start of release updates for JDK 25
• 85fedbf: 8344607: Link Time Optimization - basic support for clang
• 5a0899f: 8345302: Building microbenchmarks require larger Java heap
• 1ece4f9: 8345514: Should use internal class name when calling ClassLoader.getResourceAsByteArray
• ef8da28: 8345591: [aarch64] macroAssembler_aarch64.cpp compile fails ceil_log2 not declared
• 7513b13: 8328944: NMT reports "unknown" memory
• 691e692: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util
• 97b8a09: 8345339: JFR: Missing javadoc for RecordingStream::onMetadata
• 456c71d: 8343699: [aarch64] Bug in MacroAssembler::klass_decode_mode()
• 308357c: 8345578: New test in JDK-8343622 fails with a promoted build
• ... and 148 more: https://git.openjdk.org/jdk/compare/3b21a298c29d88720f6bfb2dc1f3305b6a3db307...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@rwestrel The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (faacb5d7)
• 00: Full (ecc9a7b7)

[eme64]

Looks reasonable, thanks for the fix!

I linked the issue with JDK-8341834 on JBS - after all that had the same issue of Replicate->Cast

[eme64]

You should add the new bug id to the test.

[eme64]

Maybe you should also update the summary, and say that the issue is about replicate and cast.

[rwestrel]

Done in new commit.

[vnkozlov]

Good.

[eme64]

Thanks for the update - still good :)

[vnkozlov]

Update is good.

[rwestrel]

@eme64 @vnkozlov thanks for the reviews

[rwestrel]

/integrate

[openjdk]

Going to push as commit 874d68a.
Since your change was applied there have been 172 commits pushed to the master branch:

• d9a2213: 8345299: C2: some nodes can still have incorrect control after do_range_check()
• 2286fae: 8345159: RISCV: Fix -Wzero-as-null-pointer-constant warning in emit_static_call_stub
• 8403285: 8268145: [macos] Rendering artifacts is seen when text inside the JTable with TableCellEditor having JTextfield
• aa38284: 8345435: Eliminate tier1_compiler_not_xcomp group
• 9284602: 8345628: [BACKOUT] JDK-8287122 Use gcc12 -ftrivial-auto-var-init=pattern in debug builds
• 41c8971: 8287122: Use gcc12 -ftrivial-auto-var-init=pattern in debug builds
• 5da0eee: 8285692: Enable _FORTIFY_SOURCE=2 when building with Clang
• daa2ba5: 8339622: Regression in make open-hotspot-xcode-project
• 6f6bce5: 8344559: Log is spammed by missing pandoc warnings when building man pages
• 5f30a8d: 8345424: Move FindDebuginfoFiles out of FileUtils.gmk
• ... and 162 more: https://git.openjdk.org/jdk/compare/3b21a298c29d88720f6bfb2dc1f3305b6a3db307...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rwestrel Pushed as commit 874d68a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.