Skip to content

8345220: Serial: Refactor TenuredGeneration::promotion_attempt_is_safe #22444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Nov 28, 2024

Trivial using MIN2 to replace >= and || for better readability.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345220: Serial: Refactor TenuredGeneration::promotion_attempt_is_safe (Enhancement - P4)

Reviewers

Reviewers without OpenJDK IDs

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22444/head:pull/22444
$ git checkout pull/22444

Update a local copy of the PR:
$ git checkout pull/22444
$ git pull https://git.openjdk.org/jdk.git pull/22444/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22444

View PR using the GUI difftool:
$ git pr show -t 22444

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22444.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2024

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 28, 2024

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345220: Serial: Refactor TenuredGeneration::promotion_attempt_is_safe

Reviewed-by: tschatzl, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 095e769: 8345237: 32-bit Zero builds fail with assert(has_klass_gap()) failed: precondition
  • 1a7a184: 8344293: Remove empty Test files left over from JDK-8305895
  • f2c0d18: 8344989: Test java/foreign/TestLinker.java failed with zero: IllegalStateException: libffi call failed with status: FFI_BAD_TYPEDEF
  • 08d563b: 8345110: RISC-V: Optimize and and clean up byte reverse assembler routines
  • 959fa4a: 8344299: SM cleanup in javax.naming modules
  • 43000a3: 8345075: java.lang.module.ModuleDescriptor constructor could be made private
  • fd742af: 8344394: Remove SecurityManager and related calls from java.management.rmi

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8345220 8345220: Serial: Refactor TenuredGeneration::promotion_attempt_is_safe Nov 28, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 28, 2024
@openjdk
Copy link

openjdk bot commented Nov 28, 2024

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Nov 28, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2024

Webrevs

Copy link
Contributor

@tschatzl tschatzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 28, 2024
Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Dec 2, 2024

Going to push as commit 0b0f83c.
Since your change was applied there have been 24 commits pushed to the master branch:

  • dfcbfb5: 8345236: RISC-V: Remove revb_h_h_u and revb_h_w_u macro assembler routines
  • ac2fede: 8344041: Re-enable external specs page
  • 1c4c653: 8345247: Deproblemlist test/jdk/javax/swing/JRadioButton/8075609/bug8075609.java
  • f5ebda4: 8345173: BlockLocationPrinter::print_location misses a ResourceMark
  • c40b570: 8343775: Add since checker tests to the security area modules
  • 50b4cbd: 8345102: [s390x/ppc] ShowRegistersOnAssertTest.java fails after 8343756
  • 28ae281: 8337511: Implement JEP 404: Generational Shenandoah (Experimental)
  • 029ace0: 8336041: Doccheck: the jfr command doesn't show the correct command-line options
  • 2beb2b6: 8345234: Build system erroneously treats 32-bit x86 Zero as deprecated
  • ed03f0d: 8345145: Display javap LineNumberTable and LocalVariableTable iff disassembled code output with -c or -v
  • ... and 14 more: https://git.openjdk.org/jdk/compare/3b21a298c29d88720f6bfb2dc1f3305b6a3db307...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 2, 2024
@openjdk openjdk bot closed this Dec 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 2, 2024
@openjdk
Copy link

openjdk bot commented Dec 2, 2024

@albertnetymk Pushed as commit 0b0f83c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the trivial branch December 2, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants