8345178: RISC-V: Add gtests for narrow cmpxchg

[robehn]

Hi, please consider.

This adds tests of aligned narrow cmpxchg.

Note: Google Test filter = *RiscV*
[==========] Running 5 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 5 tests from RiscV
...
[ RUN      ] RiscV.cmpxchg_int16_lr_sc_vm
[       OK ] RiscV.cmpxchg_int16_lr_sc_vm (2 ms)
[ RUN      ] RiscV.cmpxchg_int8_lr_sc_vm
[       OK ] RiscV.cmpxchg_int8_lr_sc_vm (1 ms)
[ RUN      ] RiscV.cmpxchg_int16_maybe_zacas_vm
[       OK ] RiscV.cmpxchg_int16_maybe_zacas_vm (1 ms)
[ RUN      ] RiscV.cmpxchg_int8_maybe_zacas_vm
[       OK ] RiscV.cmpxchg_int8_maybe_zacas_vm (1 ms)
[----------] 5 tests from RiscV (20831 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test suite ran. (20834 ms total)
[  PASSED  ] 5 tests.

Executed with -XX:+UnlockExperimentalVMOptions -XX:+UseZacas

Thanks, Robbin

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345178: RISC-V: Add gtests for narrow cmpxchg (Sub-task - P4)

Reviewers

• Fei Yang (@RealFYang - Reviewer)
• Hamlin Li (@Hamlin-Li - Reviewer) Review applies to 22e8c4e6

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22445/head:pull/22445
$ git checkout pull/22445

Update a local copy of the PR:
$ git checkout pull/22445
$ git pull https://git.openjdk.org/jdk.git pull/22445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22445

View PR using the GUI difftool:
$ git pr show -t 22445

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22445.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345178: RISC-V: Add gtests for narrow cmpxchg

Reviewed-by: fyang, mli

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 48 new commits pushed to the master branch:

• a49f077: 8345221: Replace legacy with new Provider APIs in SunNativeGSS
• 2be07b5: 8324491: Keyboard layout didn't keep its state if it was changed when dialog was active
• f37f64d: 8343736: Test java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java failed: Choice can't be controlled by keyboard
• 73b8b34: 8344368: IndependenceSwingTest.java and IndependenceAWTTest.java failed: Selected text & clipboard contents differs
• 9267dfa: 8344589: Update IANA Language Subtag Registry to Version 2024-11-19
• 293323c: 8340141: C1: rework ciMethod::equals following 8338471
• 76e874c: 8345319: Fix the tag type in PoolEntry and AnnotationValue
• e9f6ba0: 8345293: Fix generational Shenandoah with compact headers
• e1910f2: 8345397: Remove from g1HeapRegionRemSet.cpp
• 3c60f0b: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed
• ... and 38 more: https://git.openjdk.org/jdk/compare/29c57e8b346531c8675ad853460207f67e00f946...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@robehn To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[robehn]

/label add hotspot

[openjdk]

@robehn
The hotspot label was successfully added.

[mlbridge]

Webrevs

• 03: Full (4dfd4c5f)
• 02: Full - Incremental (22e8c4e6)
• 01: Full - Incremental (b07b2c10)
• 00: Full (e129a995)

[RealFYang]

Thanks.

[Hamlin-Li]

Thanks for adding the tests!

The test code looks good. Just some minor comment below.

And one general question, will we consider to add some concurrent tests in the future? Although I don't have a good idea how to implement such tests in a stable way. :)

[robehn]

Thanks for adding the tests!

The test code looks good. Just some minor comment below.

And one general question, will we consider to add some concurrent tests in the future? Although I don't have a good idea how to implement such tests in a stable way. :)

Thanks, yes I'm adding concurrent tests also.
There is several in the gtest suit.

[Hamlin-Li]

Thanks for updating, looks good!

[robehn]

/integrate

[openjdk]

Going to push as commit 9e2b66f.
Since your change was applied there have been 61 commits pushed to the master branch:

• 4c33caa: 8344609: Check ResourceMark nesting when allocating a GrowableArray on an alternative ResourceArea
• 4b92816: 8345375: Improve debuggability of test/jdk/java/net/Socket/CloseAvailable.java
• e15912b: 8345248: Module name 'transitive' not accepted for requires transitive
• 521ed72: 8345357: test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java fails in ubuntu22.04
• 447f8d4: 8345353: Test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog
• 43b337e: 8344304: [s390x] ubsan: negation of -2147483648 cannot be represented in type 'int'
• 7ec36bb: 8343001: Adjust XSLT and XPath Extension Function Property
• c143138: 8345351: RISC-V: Rename macro-assembler routine cmpxchg_weak to weak_cmpxchg
• 4237897: 8345341: Fix incorrect log message in JDI stop002t test
• 82e8aa6: 8345415: Rollback JDK-8301991 change on xmlsecurity_de.properties
• ... and 51 more: https://git.openjdk.org/jdk/compare/29c57e8b346531c8675ad853460207f67e00f946...master

Your commit was automatically rebased without conflicts.

[openjdk]

@robehn Pushed as commit 9e2b66f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.