Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260461: Modernize jsr166 tck tests #2245

Closed
wants to merge 1 commit into from

Conversation

Martin-Buchholz
Copy link
Member

@Martin-Buchholz Martin-Buchholz commented Jan 26, 2021

/cc core-libs


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

  • Doug Lea (@DougLea - Reviewer) ⚠️ Review applies to 86767c464366decdb46ee71399240ace905a9957

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2245/head:pull/2245
$ git checkout pull/2245

@Martin-Buchholz
Copy link
Member Author

/issue add JDK-8260461

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 26, 2021

👋 Welcome back martin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr Pull request is ready for review core-libs core-libs-dev@openjdk.org labels Jan 26, 2021
@openjdk
Copy link

openjdk bot commented Jan 26, 2021

@Martin-Buchholz
The core-libs label was successfully added.

@openjdk
Copy link

openjdk bot commented Jan 26, 2021

@Martin-Buchholz This issue is referenced in the PR title - it will now be updated.

@mlbridge
Copy link

mlbridge bot commented Jan 26, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 27, 2021

@Martin-Buchholz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260461: Modernize jsr166 tck tests

Reviewed-by: dl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2021
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 27, 2021
@Martin-Buchholz
Copy link
Member Author

jcheck bot caught trailing whitespace in commit

@Martin-Buchholz
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jan 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 28, 2021
@openjdk
Copy link

openjdk bot commented Jan 28, 2021

@Martin-Buchholz Since your change was applied there have been 43 commits pushed to the master branch:

  • 2b166d8: 8260596: Comment cleanup in BigInteger
  • 1de3c55: 8260584: Shenandoah: simplify "Concurrent Thread Roots" logging
  • bbbfaa5: 8249262: Initialize InstanceKlass::_package_entry during CDS dump time
  • 3aabbd7: 8260432: allocateSpaceForGP in freetypeScaler.c might leak memory
  • abc4300: 8257746: Regression introduced with JDK-8250984 - memory might be null in some machines
  • 13ca433: 8259628: jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java fails intermittently
  • baf46ba: 8259801: Enable XML Signature secure validation mode by default
  • 20e7df5: 8260466: Test TestHeapDumpOnOutOfMemoryError.java needs multiple @test sections
  • 11d6467: 8260407: cmp != __null && cmp->Opcode() == Op_CmpL failure with -XX:StressLongCountedLoop=200000000 in lucene
  • d07af2b: 8255531: MethodHandles::permuteArguments throws NPE when duplicating dropped arguments
  • ... and 33 more: https://git.openjdk.java.net/jdk/compare/e1411fd4d4beef5d792d715751fd8c4980be3bab...master

Your commit was automatically rebased without conflicts.

Pushed as commit 81e9e6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
2 participants