8345237: 32-bit Zero builds fail with assert(has_klass_gap()) failed: precondition

[shipilev]

JDK-8305895 started to wrap oopDesc::set_klass_gap() calls with oopDesc::has_klass_gap(), but missed a spot in Zero. So now 32-bit Zero builds fail like this:

=== Output from failing command(s) repeated here ===
* For target buildtools_create_symbols_javac__the.COMPILE_CREATE_SYMBOLS_batch:
#
# A fatal error has been detected by the Java Runtime Environment:
#
# Internal Error (/home/shade/trunks/jdk/src/hotspot/share/oops/oop.inline.hpp:167), pid=1592865, tid=1592897
# assert(has_klass_gap()) failed: precondition

Additional testing:

• Linux x86_32 zero fastdebug build now passes

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345237: 32-bit Zero builds fail with assert(has_klass_gap()) failed: precondition (Bug - P4)

Reviewers

• Hamlin Li (@Hamlin-Li - Reviewer)
• Julian Waters (@TheShermanTanker - Committer)
• Roman Kennke (@rkennke - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22453/head:pull/22453
$ git checkout pull/22453

Update a local copy of the PR:
$ git checkout pull/22453
$ git pull https://git.openjdk.org/jdk.git pull/22453/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22453

View PR using the GUI difftool:
$ git pr show -t 22453

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22453.diff

Using Webrev

Link to Webrev Comment

[shipilev]

Hey @rkennke ^ :)

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345237: 32-bit Zero builds fail with assert(has_klass_gap()) failed: precondition

Reviewed-by: mli, jwaters, rkennke

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 08d563b: 8345110: RISC-V: Optimize and and clean up byte reverse assembler routines
• 959fa4a: 8344299: SM cleanup in javax.naming modules
• 43000a3: 8345075: java.lang.module.ModuleDescriptor constructor could be made private
• fd742af: 8344394: Remove SecurityManager and related calls from java.management.rmi
• 3b21a29: 8345175: Further cleanup in java.logging and jdk.internal.logger after JEP 486 integration
• 7dc00d3: 8345154: IGV: Show Parse and Assertion Predicate type as extra label
• 1e086b1: 8340103: Add internal set_flag function to VMATree
• db535c8: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation
• edfe285: 8344306: RISC-V: Add zicond

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1fe3faf6)

[Hamlin-Li]

Looks good.

[shipilev]

Trivial, right?

[Hamlin-Li]

Trivial, right?

It does not matter, you already got 3 approval. :)

[shipilev]

Trivial, right?
It does not matter, you already got 3 approval. :)

Still does matter, 24-hour rule for Hotspot changes by default. But I think there are only a few people care about Zero, and about half of them are in this PR :)

[rkennke]

Trivial, right?

Yes.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit 095e769.
Since your change was applied there have been 11 commits pushed to the master branch:

• 1a7a184: 8344293: Remove empty Test files left over from JDK-8305895
• f2c0d18: 8344989: Test java/foreign/TestLinker.java failed with zero: IllegalStateException: libffi call failed with status: FFI_BAD_TYPEDEF
• 08d563b: 8345110: RISC-V: Optimize and and clean up byte reverse assembler routines
• 959fa4a: 8344299: SM cleanup in javax.naming modules
• 43000a3: 8345075: java.lang.module.ModuleDescriptor constructor could be made private
• fd742af: 8344394: Remove SecurityManager and related calls from java.management.rmi
• 3b21a29: 8345175: Further cleanup in java.logging and jdk.internal.logger after JEP 486 integration
• 7dc00d3: 8345154: IGV: Show Parse and Assertion Predicate type as extra label
• 1e086b1: 8340103: Add internal set_flag function to VMATree
• db535c8: 8313367: SunMSCAPI cannot read Local Computer certs w/o Windows elevation
• ... and 1 more: https://git.openjdk.org/jdk/compare/d33ad07c32f23aee799750c9964ab26d0cbe56f4...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 095e769.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.