8345267: Fix memory leak in JVMCIEnv dtor

[dougxc]

The ALLOW_C_FUNCTION macro takes the identifier for the relevant C function, followed by a statement containing the use as additional (variadic) macro args. This PR fixes a use of this macro where the leading identifier arg was being omitted.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345267: Fix memory leak in JVMCIEnv dtor (Bug - P4)

Reviewers

• Volker Simonis (@simonis - Reviewer)
• Kim Barrett (@kimbarrett - Reviewer) Review applies to c789f049

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22471/head:pull/22471
$ git checkout pull/22471

Update a local copy of the PR:
$ git checkout pull/22471
$ git pull https://git.openjdk.org/jdk.git pull/22471/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22471

View PR using the GUI difftool:
$ git pr show -t 22471

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22471.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345267: Fix memory leak in JVMCIEnv dtor

Reviewed-by: simonis, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• ac2fede: 8344041: Re-enable external specs page
• 1c4c653: 8345247: Deproblemlist test/jdk/javax/swing/JRadioButton/8075609/bug8075609.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (35c0c3de)
• 00: Full (c789f049)

[simonis]

Looks good. Have you checked (maybe with a simple grep command) if we don't have other instances of this issue?

[kimbarrett]

Looks good.

[kimbarrett]

Looks good. Have you checked (maybe with a simple grep command) if we don't have other instances of this issue?

I've just recently looked at all of the uses of that macro for other reasons, and this was the only one I found like this.

[openjdk]

@dougxc Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[dougxc]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit b823398.
Since your change was applied there have been 7 commits pushed to the master branch:

• 9a48e4d: 8345177: RISC-V: Add gtests for cmpxchg
• e3b679a: 8345176: Add tests to verify java.net.Socket constructors close the socket on failure
• c7be41e: 8340133: Add concise usage message to the java executable
• 0b0f83c: 8345220: Serial: Refactor TenuredGeneration::promotion_attempt_is_safe
• dfcbfb5: 8345236: RISC-V: Remove revb_h_h_u and revb_h_w_u macro assembler routines
• ac2fede: 8344041: Re-enable external specs page
• 1c4c653: 8345247: Deproblemlist test/jdk/javax/swing/JRadioButton/8075609/bug8075609.java

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit b823398.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.