Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259816: Typo in java.util.stream package description #2249

Closed

Conversation

@stuart-marks
Copy link
Member

@stuart-marks stuart-marks commented Jan 27, 2021

Fix a typo, and change an example to use Stream.toList().


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259816: Typo in java.util.stream package description

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2249/head:pull/2249
$ git checkout pull/2249

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 27, 2021

👋 Welcome back smarks! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 27, 2021

@stuart-marks The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs label Jan 27, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 27, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jan 27, 2021

@stuart-marks This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259816: Typo in java.util.stream package description

Reviewed-by: iris, lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 102 new commits pushed to the master branch:

  • 311a0a9: 8259808: Add JFR event to detect GC locker stall
  • f353fcf: 8258894: C2: Forbid GCM to move stores into loops
  • ac276bb: 8257074: Update the ByteBuffers micro benchmark
  • 7ed591c: 8260314: Replace border="1" on tables with CSS
  • e696baa: 8260448: Simplify ManagementFactory$PlatformMBeanFinder
  • b3c8a52: 8259050: Error recovery in lexer could be improved
  • bf15c70: 8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"
  • 3e4194c: 8260022: [ppc] os::print_function_and_library_name shall resolve function descriptors transparently
  • fa40a96: 8253420: Refactor HeapRegionManager::find_highest_free
  • 4d004c9: 8260449: Remove stale declaration of SATBMarkQueue::apply_closure_and_empty()
  • ... and 92 more: https://git.openjdk.java.net/jdk/compare/35c9da70316da21a6be2fd92a5e5b5f193bdd9d6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 27, 2021
@naotoj
naotoj approved these changes Jan 27, 2021
@stuart-marks
Copy link
Member Author

@stuart-marks stuart-marks commented Jan 27, 2021

/integrate

@openjdk openjdk bot closed this Jan 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 27, 2021

@stuart-marks Since your change was applied there have been 104 commits pushed to the master branch:

  • 0eed2c3: 8259359: javac does not attribute unexpected super constructor invocation qualifier, and may crash
  • 684c855: 8260524: validate-source fails on test/jdk/jdk/jfr/event/gc/detailed/TestGCLockerEvent.java
  • 311a0a9: 8259808: Add JFR event to detect GC locker stall
  • f353fcf: 8258894: C2: Forbid GCM to move stores into loops
  • ac276bb: 8257074: Update the ByteBuffers micro benchmark
  • 7ed591c: 8260314: Replace border="1" on tables with CSS
  • e696baa: 8260448: Simplify ManagementFactory$PlatformMBeanFinder
  • b3c8a52: 8259050: Error recovery in lexer could be improved
  • bf15c70: 8260460: GitHub actions still fail on Linux x86_32 with "Could not configure libc6:i386"
  • 3e4194c: 8260022: [ppc] os::print_function_and_library_name shall resolve function descriptors transparently
  • ... and 94 more: https://git.openjdk.java.net/jdk/compare/35c9da70316da21a6be2fd92a5e5b5f193bdd9d6...master

Your commit was automatically rebased without conflicts.

Pushed as commit eb92368.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants