8345471: Clean up compiler/intrinsics/sha/cli tests

[djelinski]

Merge all the GenericTestCaseForUnsupportedXXXCPU and GenericTestCaseForOtherCPU into GenericTestCaseForUnsupportedCPU.java.

The CPU-specific files are almost identical; I chose to resolve the differences in favor of the AArch64 version. The OtherCPU version looks wrong, and it wasn't executed on any supported platform.

The tests continue to pass on linux-aarch64/x64, windows-x64 and mac-aarch64. I didn't test other platforms.

After the change, the tests will start running on PPC and S390. They will also automatically run on any new architectures.

For those interested in historical background, when the tests were introduced, there were only 2 supported CPU architectures. X86 did not support any of the intrinsics, and the X86 test case did not even call getPredicateForOption. The call to getPredicateForOption was added in f2e9b82, and since then all the cases are the same.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345471: Clean up compiler/intrinsics/sha/cli tests (Enhancement - P4)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22517/head:pull/22517
$ git checkout pull/22517

Update a local copy of the PR:
$ git checkout pull/22517
$ git pull https://git.openjdk.org/jdk.git pull/22517/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22517

View PR using the GUI difftool:
$ git pr show -t 22517

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22517.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345471: Clean up compiler/intrinsics/sha/cli tests

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 242 new commits pushed to the master branch:

• 18d1d61: 8346046: Enable copyright header format check
• a7631cc: 8346235: RISC-V: Optimize bitwise AND with mask values
• 929d4a5: 8346231: RISC-V: Fix incorrect assertion in SharedRuntime::generate_handler_blob
• 3030230: 8346278: Clean up some flag handing in flags-cflags.m4
• fd0207d: 8345327: JDK 24 RDP1 L10n resource files update
• 31c3b19: 8346174: UMAX/UMIN are missing from XXXVector::reductionOperations
• c75b1d4: 8346082: Output JVMTI agent information in hserr files
• 51662c2: 8346232: Remove leftovers of the jar --normalize feature
• d335941: 8345678: compute_modifiers should not be in create_mirror
• 57adf64: 8346261: Cleanup in JDP tests
• ... and 232 more: https://git.openjdk.org/jdk/compare/dfa5620ff3d57b71ccaf09ca8e71fa85d93ceb00...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@djelinski The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5c65f963)

[vnkozlov]

Good.

[djelinski]

Thanks for the review @vnkozlov. Still waiting for a second reviewer...

[bridgekeeper]

@djelinski This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[djelinski]

I'd like to merge this early next week; if anyone still wants to review this but needs more time, please leave a note.

[djelinski]

/integrate

[openjdk]

Going to push as commit 3b9732e.
Since your change was applied there have been 433 commits pushed to the master branch:

• ed0b555: 8344035: Replace predicate walking code in Loop Unswitching with a predicate visitor
• b37f123: 8347407: [BACKOUT] C1/C2 don't handle allocation failure properly during initialization (RuntimeStub::new_runtime_stub fatal crash)
• 1f7925c: 8347270: Remove unix_getParentPidAndTimings, unix_getChildren and unix_getCmdlineAndUserInfo
• 9fafd63: 8346828: javax/swing/JScrollBar/4865918/bug4865918.java still fails in CI
• f04a642: 8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id"
• 3145278: 8346727: JvmtiVTMSTransitionDisabler deadlock
• 761774a: 8346143: add ClearAllFramePops function to speedup debugger single stepping in some cases
• 6f1f2f2: 8347063: Add comments in ClassFileFormatVersion for class file format evolution history
• 10f7142: 8347295: Fix WinResourceTest to make it work with WiX v4.0+
• 01c8ba2: 8347298: Bug in JPackageCommand.ignoreFakeRuntime()
• ... and 423 more: https://git.openjdk.org/jdk/compare/dfa5620ff3d57b71ccaf09ca8e71fa85d93ceb00...master

Your commit was automatically rebased without conflicts.

[openjdk]

@djelinski Pushed as commit 3b9732e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.