JDK-8260426: awt debug_mem.c DMem_AllocateBlock might leak memory

[MBaesken]

It seems that the function DMem_AllocateBlock (debug_mem.c) has an early return that might lead to memory leaks.
See also the sonar issue Potential leak of memory pointed to by 'header' :
https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=c&open=AXck8B7zBBG2CXpcngZM&resolved=false&severities=BLOCKER&types=BUG

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260426: awt debug_mem.c DMem_AllocateBlock might leak memory

Reviewers

• Prasanta Sadhukhan (@prsadhuk - Reviewer)
• Alexey Ivanov (@aivanov-jdk - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2252/head:pull/2252
$ git checkout pull/2252

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (422c070)

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260426: awt debug_mem.c DMem_AllocateBlock might leak memory

Reviewed-by: psadhukhan, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• c52212b: Merge
• 408772c: 8259025: Record compact constructor using Objects.requireNonNull
• 81e730e: 8259276: C2: Empty expression stack when reexecuting tableswitch/lookupswitch instructions after deoptimization
• c5ab7c3: 8260284: C2: assert(_base == Int) failed: Not an Int
• eb92368: 8259816: Typo in java.util.stream package description
• 0eed2c3: 8259359: javac does not attribute unexpected super constructor invocation qualifier, and may crash
• 684c855: 8260524: validate-source fails on test/jdk/jdk/jfr/event/gc/detailed/TestGCLockerEvent.java
• 311a0a9: 8259808: Add JFR event to detect GC locker stall
• f353fcf: 8258894: C2: Forbid GCM to move stores into loops
• ac276bb: 8257074: Update the ByteBuffers micro benchmark
• ... and 6 more: https://git.openjdk.java.net/jdk/compare/4d004c9447fc68407bb62453e3bc00daf09ecfbd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[MBaesken]

/integrate

[openjdk]

@MBaesken Since your change was applied there have been 21 commits pushed to the master branch:

• 396a496: 8260467: Move well-known classes from systemDictionary.hpp to vmClasses.hpp
• 62ffe75: Merge
• e28e111: 8260370: C2: LoopLimit node is not eliminated
• 7030d2e: 8260200: G1: Remove unnecessary update in FreeRegionList::remove_starting_at
• c7661ae: 8260561: [doc] HexFormat has incorrect @SInCE tag
• c52212b: Merge
• 408772c: 8259025: Record compact constructor using Objects.requireNonNull
• 81e730e: 8259276: C2: Empty expression stack when reexecuting tableswitch/lookupswitch instructions after deoptimization
• c5ab7c3: 8260284: C2: assert(_base == Int) failed: Not an Int
• eb92368: 8259816: Typo in java.util.stream package description
• ... and 11 more: https://git.openjdk.java.net/jdk/compare/4d004c9447fc68407bb62453e3bc00daf09ecfbd...master

Your commit was automatically rebased without conflicts.

Pushed as commit 11a70d1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.