Skip to content

8345404: [ppc64le] ProblemList TestAllocOutOfMemory.java#large #22520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Dec 3, 2024

The current problem listing of the test is broken because of CODETOOLS-7902265 so we have to adjust it and add '#large' .
Seems the other subtests do not fail so I do not exclude them, just '#large' .


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345404: [ppc64le] ProblemList TestAllocOutOfMemory.java#large (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22520/head:pull/22520
$ git checkout pull/22520

Update a local copy of the PR:
$ git checkout pull/22520
$ git pull https://git.openjdk.org/jdk.git pull/22520/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22520

View PR using the GUI difftool:
$ git pr show -t 22520

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22520.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial. Thanks for fixing it!

@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345404: [ppc64le] ProblemList TestAllocOutOfMemory.java#large

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e1910f2: 8345397: Remove from g1HeapRegionRemSet.cpp
  • 3c60f0b: 8345296: AArch64: VM crashes with SIGILL when prctl is disallowed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title JDK-8345404: [ppc64le] ProblemList TestAllocOutOfMemory.java#large 8345404: [ppc64le] ProblemList TestAllocOutOfMemory.java#large Dec 3, 2024
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 3, 2024
@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@MBaesken To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@MBaesken
Copy link
Member Author

MBaesken commented Dec 4, 2024

Thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

Going to push as commit 943aa03.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 9e2b66f: 8345178: RISC-V: Add gtests for narrow cmpxchg
  • 4c33caa: 8344609: Check ResourceMark nesting when allocating a GrowableArray on an alternative ResourceArea
  • 4b92816: 8345375: Improve debuggability of test/jdk/java/net/Socket/CloseAvailable.java
  • e15912b: 8345248: Module name 'transitive' not accepted for requires transitive
  • 521ed72: 8345357: test/jdk/javax/swing/JRadioButton/8033699/bug8033699.java fails in ubuntu22.04
  • 447f8d4: 8345353: Test for JDK-8344800 W3C DTDs and XSDs in the built-in Catalog
  • 43b337e: 8344304: [s390x] ubsan: negation of -2147483648 cannot be represented in type 'int'
  • 7ec36bb: 8343001: Adjust XSLT and XPath Extension Function Property
  • c143138: 8345351: RISC-V: Rename macro-assembler routine cmpxchg_weak to weak_cmpxchg
  • 4237897: 8345341: Fix incorrect log message in JDI stop002t test
  • ... and 14 more: https://git.openjdk.org/jdk/compare/3eaa7615cd7dc67eb78fb0a8f89d4e6662a0db37...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2024
@openjdk openjdk bot closed this Dec 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@MBaesken Pushed as commit 943aa03.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants