Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345421: (bf) Create specific test for temporary direct buffers and the buffer size limit #22525

Closed
wants to merge 3 commits into from

Conversation

bplb
Copy link
Member

@bplb bplb commented Dec 3, 2024

Add a specific test for JDK-8344882.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345421: (bf) Create specific test for temporary direct buffers and the buffer size limit (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22525/head:pull/22525
$ git checkout pull/22525

Update a local copy of the PR:
$ git checkout pull/22525
$ git pull https://git.openjdk.org/jdk.git pull/22525/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22525

View PR using the GUI difftool:
$ git pr show -t 22525

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22525.diff

Using Webrev

Link to Webrev Comment

@bplb
Copy link
Member Author

bplb commented Dec 3, 2024

The proposed test fails on all platforms before the fix of JDK-8344882 is applied and succeeds afterwards.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2024

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@bplb
Copy link
Member Author

bplb commented Dec 3, 2024

The noreg-other label will be removed from JDK-8344882 once (if) this request is integrated.

@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345421: (bf) Create specific test for temporary direct buffers and the buffer size limit

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 140 new commits pushed to the master branch:

  • 1e9204f: 8345273: Fix -Wzero-as-null-pointer-constant warnings in s390 code
  • c40140e: 8334581: Remove no-arg constructor BasicSliderUI()
  • 8de0622: 8345767: javax/swing/JSplitPane/4164779/JSplitPaneKeyboardNavigationTest.java fails in ubuntu22.04
  • abcd23f: 8334756: javac crashed on call to non-existent generic method with explicit annotated type arg
  • 2ddaa46: 8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended
  • c631719: 8343170: java/awt/Cursor/JPanelCursorTest/JPanelCursorTest.java does not show the default cursor
  • 29d648c: 8341781: Improve Min/Max node identities
  • 4c39e9f: 8344924: Default CA certificates loaded despite request to use custom keystore
  • 0f03554: 8342469: Improve API documentation for java.lang.classfile.instruction
  • 9bd70ec: 8345888: Broken links in the JDK 24 JavaDoc API documentation, build 27
  • ... and 130 more: https://git.openjdk.org/jdk/compare/a49f0776eb176129f558b6fab3f50e0453f8cbcb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 3, 2024
@openjdk
Copy link

openjdk bot commented Dec 3, 2024

@bplb The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Dec 3, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 3, 2024

Webrevs

@AlanBateman
Copy link
Contributor

There are some stability issues since the change went in so maybe hold off on adding a test as it's possible the change may have be temporarily reverted.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 11, 2024
@bplb
Copy link
Member Author

bplb commented Dec 11, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 11, 2024

Going to push as commit cce5808.
Since your change was applied there have been 156 commits pushed to the master branch:

  • cf0e1aa: 8345335: Add excluded jdk_foreign tests to manual group
  • 2c4567a: 8342651: Refactor array constant to use an array of jbyte
  • 72c6daf: 8346007: Incorrect copyright header in UModLNodeIdealizationTests.java
  • cc47918: 8345040: Clean up unused variables and code in generate_native_wrapper
  • c34b87c: 8345659: Fix broken alignment after ReservedSpace splitting in GC code
  • e294899: 8345647: Fix recent NULL usage backsliding in Shenandoah
  • d381d58: 8332268: C2: Add missing optimizations for UDivI/L and UModI/L and unify the shared logic with the signed nodes
  • 45c914c: 8343607: C2: Shenandoah crashes during barrier expansion in Continuation::enter
  • a21d21f: 8345609: [C1] LIR Operations with one input should be implemented as LIR_Op1
  • 2382a2d: 8345661: Simplify page size alignment in code heap reservation
  • ... and 146 more: https://git.openjdk.org/jdk/compare/a49f0776eb176129f558b6fab3f50e0453f8cbcb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 11, 2024
@openjdk openjdk bot closed this Dec 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 11, 2024
@openjdk
Copy link

openjdk bot commented Dec 11, 2024

@bplb Pushed as commit cce5808.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@bplb bplb deleted the tempbuffer-limit-8345421 branch December 11, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants