-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8345421: (bf) Create specific test for temporary direct buffers and the buffer size limit #22525
Conversation
…he buffer size limit
The proposed test fails on all platforms before the fix of JDK-8344882 is applied and succeeds afterwards. |
👋 Welcome back bpb! A progress list of the required criteria for merging this PR into |
The |
@bplb This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 140 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There are some stability issues since the change went in so maybe hold off on adding a test as it's possible the change may have be temporarily reverted. |
/integrate |
Going to push as commit cce5808.
Your commit was automatically rebased without conflicts. |
Add a specific test for JDK-8344882.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22525/head:pull/22525
$ git checkout pull/22525
Update a local copy of the PR:
$ git checkout pull/22525
$ git pull https://git.openjdk.org/jdk.git pull/22525/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22525
View PR using the GUI difftool:
$ git pr show -t 22525
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22525.diff
Using Webrev
Link to Webrev Comment