8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended

[alexmenkov]

The PR fixes race in the test between ThreadStart/ThreadEnd callbacks and agent thread:
The callbacks increments event counter and then do self-suspend;
Agent thread waits when expected number of events is received, then performs verification and resumes the thread, but expected counter value does not mean the threads are suspended.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended (Bug - P4)

Reviewers

• Chris Plummer (@plummercj - Reviewer)
• Leonid Mesnik (@lmesnik - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22532/head:pull/22532
$ git checkout pull/22532

Update a local copy of the PR:
$ git checkout pull/22532
$ git pull https://git.openjdk.org/jdk.git pull/22532/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22532

View PR using the GUI difftool:
$ git pr show -t 22532

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22532.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexmenkov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8305010: Test vmTestbase/nsk/jvmti/scenarios/sampling/SP05/sp05t003/TestDescription.java timed out: thread not suspended

Reviewed-by: cjplummer, lmesnik, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 276 new commits pushed to the master branch:

• eff20a3: 8345794: Backout doc change introduced by JDK-8235786
• 48e22ba: 8345693: Update JCov for class file version 69
• cc628a1: 8345287: C2: live in computation is broken
• 480b508: 8345156: C2: Add bailouts next to a few asserts
• b120404: 8345793: Update copyright year to 2024 for the build system in files where it was missed
• 7aa0cbc: 8345614: Improve AnnotationFormatError message for duplicate annotation interfaces
• 35c0053: 8345405: Add JMH showing the regression in 8341649
• 166c127: 8345726: Update mx in RunTestPrebuiltSpec to reflect change in JDK-8345302
• e821d59: 8345589: Simplify Windows definition of strtok_r
• 153dc6d: 8345133: Test sun/security/tools/jarsigner/TsacertOptionTest.java failed: Warning found in stdout
• ... and 266 more: https://git.openjdk.org/jdk/compare/8de158aefe64d493e107ef310f510bab57beb251...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexmenkov The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f2051c5f)

[plummercj]

Looks good.

[sspitsyn]

Good catch and fix.

[alexmenkov]

/integrate

[openjdk]

Going to push as commit 2ddaa46.
Since your change was applied there have been 296 commits pushed to the master branch:

• c631719: 8343170: java/awt/Cursor/JPanelCursorTest/JPanelCursorTest.java does not show the default cursor
• 29d648c: 8341781: Improve Min/Max node identities
• 4c39e9f: 8344924: Default CA certificates loaded despite request to use custom keystore
• 0f03554: 8342469: Improve API documentation for java.lang.classfile.instruction
• 9bd70ec: 8345888: Broken links in the JDK 24 JavaDoc API documentation, build 27
• 1def2d8: 8345700: tier{1,2,3}_compiler don't cover all compiler tests
• d6b5264: 8345746: Remove :resourcehogs/compiler from :hotspot_slow_compiler
• 4f855d1: 8345818: Fix SM cleanup of parsing of System property resource.bundle.debug
• a24b08f: 8345669: RISC-V: fix client build failure due to AlignVector after JDK-8343827
• 25d9deb: 8335367: [s390] Add support for load immediate on condition instructions.
• ... and 286 more: https://git.openjdk.org/jdk/compare/8de158aefe64d493e107ef310f510bab57beb251...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexmenkov Pushed as commit 2ddaa46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.