8334319: Missing keys in jpackage resource bundle

[alexeysemenyukoracle]

• Add missing resource keys to Windows property files;
• Fix the code to throw ConfigException if the service installer executable is required but not available instead of throwing the exception only when it is not found in the resource directory;
• Fix JPackageStringBundle.getFormattedString() that should not use a resource property string as a format for MessageFormat.format() if there are no arguments for formatting. MessageFormat.format() interprets characters in the format string, e.g., it removes single quotes.
• Add tests.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8334319: Missing keys in jpackage resource bundle (Bug - P4)

Reviewers

• Naoto Sato (@naotoj - Reviewer)
• Alexander Matveev (@sashamatveev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22533/head:pull/22533
$ git checkout pull/22533

Update a local copy of the PR:
$ git checkout pull/22533
$ git pull https://git.openjdk.org/jdk.git pull/22533/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22533

View PR using the GUI difftool:
$ git pr show -t 22533

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22533.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334319: Missing keys in jpackage resource bundle

Reviewed-by: naoto, almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• de3a218: 8345502: Remove doIntersectionPrivilege methods
• faa109e: 8340580: Characters in Document diagrams not in the middle
• 6aa7667: 8339535: JVM crashes with -Xshare:dump -XX:+SegmentedCodeCache
• e1695f6: 8345472: Fix incorrect format instruction for floating point max/min patterns
• baa6957: 8345507: Fix build of static launcher
• 79eb77b: 8345486: Reevaluate the classes in java.lang.classfile.components package
• f3b4350: 8345219: C2: x86_64 should not go to interpreter stubs for NaNs handling
• 16ef6e2: 8344229: Revisit SecurityManager usage in jdk.httpserver after JEP 486 integration
• 923321c: 8345447: test/jdk/javax/swing/JToolBar/4529206/bug4529206.java fails in ubuntu22.04
• 6f30762: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04
• ... and 17 more: https://git.openjdk.org/jdk/compare/521ed72b87d0fb1def6d94485e08be22632deef0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (35ae2a0a)
• 01: Full - Incremental (6898b98b)
• 00: Full (f42364c7)

[alexeysemenyukoracle]

@sashamatveev ptal

[naotoj]

Thanks. Those resource file changes look good to me.
/reviewers 2

[openjdk]

@naotoj
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[sashamatveev]

Looks good.

[alexeysemenyukoracle]

/integrate

[openjdk]

Going to push as commit ba158ed.
Since your change was applied there have been 37 commits pushed to the master branch:

• 8a3c100: 8344461: Additional cleanup in NewThreadAction
• f904480: 8345512: Remove wrapper functions for intrinsics in PQC algorithms
• 8d19a56: 8340359: Remove javax.naming.Context.APPLET
• c113f82: 8343957: Rename ObjectMonitor::owner_from() and JavaThread::_lock_id
• ea73e05: 8345181: (ch) Windows asynchronous channels may return temporary direct buffers to the buffer cache twice (win)
• ee0f88c: 8341923: java.util.Locale class specification improvements
• a72cab8: 8345148: Fix for JDK-8337317 is incomplete
• 1a73c76: 8345524: CHECK_FOR_FILES should properly handle directories
• 1d3dcdf: 8345433: (fs) Use stream to load FileTypeDetectors in Files.probeContentType
• 9740c1d: 8333572: Update jpackage.md with info related to WiX v4 and v5 support
• ... and 27 more: https://git.openjdk.org/jdk/compare/521ed72b87d0fb1def6d94485e08be22632deef0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@alexeysemenyukoracle Pushed as commit ba158ed.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.