Skip to content

8333572: Update jpackage.md with info related to WiX v4 and v5 support#22534

Closed
alexeysemenyukoracle wants to merge 1 commit intoopenjdk:masterfrom
alexeysemenyukoracle:JDK-8333572
Closed

8333572: Update jpackage.md with info related to WiX v4 and v5 support#22534
alexeysemenyukoracle wants to merge 1 commit intoopenjdk:masterfrom
alexeysemenyukoracle:JDK-8333572

Conversation

@alexeysemenyukoracle
Copy link
Member

@alexeysemenyukoracle alexeysemenyukoracle commented Dec 4, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333572: Update jpackage.md with info related to WiX v4 and v5 support (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22534/head:pull/22534
$ git checkout pull/22534

Update a local copy of the PR:
$ git checkout pull/22534
$ git pull https://git.openjdk.org/jdk.git pull/22534/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22534

View PR using the GUI difftool:
$ git pr show -t 22534

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22534.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2024

👋 Welcome back asemenyuk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@alexeysemenyukoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333572: Update jpackage.md with info related to WiX v4 and v5 support

Reviewed-by: almatvee

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 159 new commits pushed to the master branch:

  • de3a218: 8345502: Remove doIntersectionPrivilege methods
  • faa109e: 8340580: Characters in Document diagrams not in the middle
  • 6aa7667: 8339535: JVM crashes with -Xshare:dump -XX:+SegmentedCodeCache
  • e1695f6: 8345472: Fix incorrect format instruction for floating point max/min patterns
  • baa6957: 8345507: Fix build of static launcher
  • 79eb77b: 8345486: Reevaluate the classes in java.lang.classfile.components package
  • f3b4350: 8345219: C2: x86_64 should not go to interpreter stubs for NaNs handling
  • 16ef6e2: 8344229: Revisit SecurityManager usage in jdk.httpserver after JEP 486 integration
  • 923321c: 8345447: test/jdk/javax/swing/JToolBar/4529206/bug4529206.java fails in ubuntu22.04
  • 6f30762: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04
  • ... and 149 more: https://git.openjdk.org/jdk/compare/08c1f44eef56e1b6e6960596f6664fbd973c3d7e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@alexeysemenyukoracle The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org rfr Pull request is ready for review labels Dec 4, 2024
@alexeysemenyukoracle
Copy link
Member Author

@sashamatveev ptal

@mlbridge
Copy link

mlbridge bot commented Dec 4, 2024

Webrevs

Copy link
Member

@sashamatveev sashamatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2024
@alexeysemenyukoracle
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

Going to push as commit 9740c1d.
Since your change was applied there have been 159 commits pushed to the master branch:

  • de3a218: 8345502: Remove doIntersectionPrivilege methods
  • faa109e: 8340580: Characters in Document diagrams not in the middle
  • 6aa7667: 8339535: JVM crashes with -Xshare:dump -XX:+SegmentedCodeCache
  • e1695f6: 8345472: Fix incorrect format instruction for floating point max/min patterns
  • baa6957: 8345507: Fix build of static launcher
  • 79eb77b: 8345486: Reevaluate the classes in java.lang.classfile.components package
  • f3b4350: 8345219: C2: x86_64 should not go to interpreter stubs for NaNs handling
  • 16ef6e2: 8344229: Revisit SecurityManager usage in jdk.httpserver after JEP 486 integration
  • 923321c: 8345447: test/jdk/javax/swing/JToolBar/4529206/bug4529206.java fails in ubuntu22.04
  • 6f30762: 8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04
  • ... and 149 more: https://git.openjdk.org/jdk/compare/08c1f44eef56e1b6e6960596f6664fbd973c3d7e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2024
@openjdk openjdk bot closed this Dec 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@alexeysemenyukoracle Pushed as commit 9740c1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants