8345514: Should use internal class name when calling ClassLoader.getResourceAsByteArray

[calvinccheung]

This patch is for fixing an assert failure in filemap.cpp. It was introduced via JDK-8343427.
The bug is that an external class name (e.g. pkg1.Foo) was passed as the argument when calling the java method ClassLoader.getResourceAsByteArray() which expects an internal class name (e.g. pkg1/Foo).
The test case for JDK-8343427 has been updated to include package names in test classes.

Passed tiers 1 - 5 testing.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8345514: Should use internal class name when calling ClassLoader.getResourceAsByteArray (Bug - P2)

Reviewers

• Ioi Lam (@iklam - Reviewer)
• Matias Saavedra Silva (@matias9927 - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22535/head:pull/22535
$ git checkout pull/22535

Update a local copy of the PR:
$ git checkout pull/22535
$ git pull https://git.openjdk.org/jdk.git pull/22535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22535

View PR using the GUI difftool:
$ git pr show -t 22535

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22535.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ccheung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@calvinccheung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345514: Should use internal class name when calling ClassLoader.getResourceAsByteArray

Reviewed-by: iklam, matsaave

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 79 new commits pushed to the master branch:

• 1d3dcdf: 8345433: (fs) Use stream to load FileTypeDetectors in Files.probeContentType
• 9740c1d: 8333572: Update jpackage.md with info related to WiX v4 and v5 support
• de3a218: 8345502: Remove doIntersectionPrivilege methods
• faa109e: 8340580: Characters in Document diagrams not in the middle
• 6aa7667: 8339535: JVM crashes with -Xshare:dump -XX:+SegmentedCodeCache
• e1695f6: 8345472: Fix incorrect format instruction for floating point max/min patterns
• baa6957: 8345507: Fix build of static launcher
• 79eb77b: 8345486: Reevaluate the classes in java.lang.classfile.components package
• f3b4350: 8345219: C2: x86_64 should not go to interpreter stubs for NaNs handling
• 16ef6e2: 8344229: Revisit SecurityManager usage in jdk.httpserver after JEP 486 integration
• ... and 69 more: https://git.openjdk.org/jdk/compare/3a3bcd53d0b9aa55dcbc15de4d8278ce3258b31e...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@calvinccheung The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (5996c783)

[iklam]

LGTM.

[matias9927]

LGTM!

[calvinccheung]

Thanks @iklam @matias9927 for the review.

/integrate

[openjdk]

Going to push as commit 1ece4f9.
Since your change was applied there have been 113 commits pushed to the master branch:

• ef8da28: 8345591: [aarch64] macroAssembler_aarch64.cpp compile fails ceil_log2 not declared
• 7513b13: 8328944: NMT reports "unknown" memory
• 691e692: 8345565: Remove remaining SecurityManager motivated APIs from sun.reflect.util
• 97b8a09: 8345339: JFR: Missing javadoc for RecordingStream::onMetadata
• 456c71d: 8343699: [aarch64] Bug in MacroAssembler::klass_decode_mode()
• 308357c: 8345578: New test in JDK-8343622 fails with a promoted build
• 84240cc: 8344831: [REDO] CDS: Parallel relocation
• 92e9ac6: 8345294: test/jdk/java/lang/Thread/virtual/RetryMonitorEnterWhenPinned.java timeout with JTREG_TEST_THREAD_FACTORY=Virtual
• b42d79e: 8345146: [PPC64] Make intrinsic conversions between bit representations of half precision values and floats
• 7ee84d8: 8345566: Deproblemlist test/jdk/javax/swing/JComboBox/6559152/bug6559152.java
• ... and 103 more: https://git.openjdk.org/jdk/compare/3a3bcd53d0b9aa55dcbc15de4d8278ce3258b31e...master

Your commit was automatically rebased without conflicts.

[openjdk]

@calvinccheung Pushed as commit 1ece4f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.