Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04 #22540

Closed
wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Dec 4, 2024

Test is failing in OCI system citing

java.lang.Error: The scrollbar block increment is incorect
at bug4865918.main(bug4865918.java:68) 

seemingly because focus is not in scrollbar..Added stability delay to make test execution wait after frame visibility and made frame to center of screen.
Test passed in several OCI systems with this modification...


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22540/head:pull/22540
$ git checkout pull/22540

Update a local copy of the PR:
$ git checkout pull/22540
$ git pull https://git.openjdk.org/jdk.git pull/22540/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22540

View PR using the GUI difftool:
$ git pr show -t 22540

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22540.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2024

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04

Reviewed-by: abhiscxk

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 58 new commits pushed to the master branch:

  • 6c1ed0b: 8345474: Translation for instanceof is not triggered when patterns are not used in the compilation unit
  • bd6d911: 8344177: Remove SecurityManager and related calls from java.management
  • 39cdadf: 8345186: Incorrect @throws doc for MemorySegment::getString
  • 6fa5cea: 8341982: Simplify JButton/bug4323121.java
  • e13206d: 8345065: Cleanup DomainCombiner, SubjectDomainCombiner, Subject, and PrivilegedAction specifications
  • 4000e92: 8343704: Bad GC parallelism with processing Cleaner queues
  • 0c7451a: 8332686: InetAddress.ofLiteral can throw StringIndexOutOfBoundsException
  • 56d315d: 8343540: Report preview error for inherited effectively-preview methods
  • 994504c: 8329351: Add runtime/Monitor/TestRecursiveLocking.java for recursive Java monitor stress testing
  • 3d49665: 8345286: Remove use of SecurityManager API from misc areas
  • ... and 48 more: https://git.openjdk.org/jdk/compare/e023addf701ce4321040c96bd501355ece75a05c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@prsadhuk The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Dec 4, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 4, 2024

Webrevs

Copy link
Contributor

@kumarabhi006 kumarabhi006 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 4, 2024
@prsadhuk
Copy link
Contributor Author

prsadhuk commented Dec 4, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2024

Going to push as commit 6f30762.
Since your change was applied there have been 58 commits pushed to the master branch:

  • 6c1ed0b: 8345474: Translation for instanceof is not triggered when patterns are not used in the compilation unit
  • bd6d911: 8344177: Remove SecurityManager and related calls from java.management
  • 39cdadf: 8345186: Incorrect @throws doc for MemorySegment::getString
  • 6fa5cea: 8341982: Simplify JButton/bug4323121.java
  • e13206d: 8345065: Cleanup DomainCombiner, SubjectDomainCombiner, Subject, and PrivilegedAction specifications
  • 4000e92: 8343704: Bad GC parallelism with processing Cleaner queues
  • 0c7451a: 8332686: InetAddress.ofLiteral can throw StringIndexOutOfBoundsException
  • 56d315d: 8343540: Report preview error for inherited effectively-preview methods
  • 994504c: 8329351: Add runtime/Monitor/TestRecursiveLocking.java for recursive Java monitor stress testing
  • 3d49665: 8345286: Remove use of SecurityManager API from misc areas
  • ... and 48 more: https://git.openjdk.org/jdk/compare/e023addf701ce4321040c96bd501355ece75a05c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2024
@openjdk openjdk bot closed this Dec 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2024
@openjdk
Copy link

openjdk bot commented Dec 4, 2024

@prsadhuk Pushed as commit 6f30762.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the OCItest5 branch December 4, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants