-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8345468: test/jdk/javax/swing/JScrollBar/4865918/bug4865918.java fails in ubuntu22.04 #22540
Conversation
👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into |
@prsadhuk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 58 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/integrate |
Going to push as commit 6f30762.
Your commit was automatically rebased without conflicts. |
Test is failing in OCI system citing
seemingly because focus is not in scrollbar..Added stability delay to make test execution wait after frame visibility and made frame to center of screen.
Test passed in several OCI systems with this modification...
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22540/head:pull/22540
$ git checkout pull/22540
Update a local copy of the PR:
$ git checkout pull/22540
$ git pull https://git.openjdk.org/jdk.git pull/22540/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22540
View PR using the GUI difftool:
$ git pr show -t 22540
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22540.diff
Using Webrev
Link to Webrev Comment